From dff8743b4ddddc9170369cab8b84a020bcd1af60 Mon Sep 17 00:00:00 2001 From: Trezy Date: Thu, 6 Dec 2018 08:33:24 -0600 Subject: [PATCH 1/3] ci(lint): allow commitlint to run as a parallel task in CI --- .circleci/config.yml | 21 ++++++++++++++++----- 1 file changed, 16 insertions(+), 5 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index bfbcb02..630612e 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -94,6 +94,17 @@ jobs: paths: - css + commitlint: + <<: *defaults + + steps: + - attach_workspace: + at: . + + - run: + name: Lint commit messages + command: npx semantic-commitlint -- --ci + lint: <<: *defaults @@ -105,10 +116,6 @@ jobs: name: Lint styles command: npx stylelint -- --fix - - run: - name: Lint commit messages - command: npx semantic-commitlint -- --ci - # test: # <<: *defaults @@ -163,6 +170,9 @@ workflows: main: jobs: - checkout + - commitlint: + requires: + - checkout - install-dependencies: requires: - checkout @@ -185,9 +195,10 @@ workflows: - develop - release: requires: - # - test + - commitlint - build - lint + # - test filters: branches: only: master From f4eb84a90d9bd7095ef4d18a24651b93e9c1df03 Mon Sep 17 00:00:00 2001 From: Trezy Date: Thu, 6 Dec 2018 08:35:23 -0600 Subject: [PATCH 2/3] ci: allow build to run on all branches Since we don't have any tests yet, we want to make sure the build runs successfully on all branches. That way we can at least verify that the build works correctly. closes #13 --- .circleci/config.yml | 5 ----- 1 file changed, 5 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 630612e..c2de6da 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -188,11 +188,6 @@ workflows: - build: requires: - install-dependencies - filters: - branches: - only: - - master - - develop - release: requires: - commitlint From 9ac19dfb65c699fe4991fc7b175d5d79b3763fd3 Mon Sep 17 00:00:00 2001 From: Trezy Date: Thu, 6 Dec 2018 08:40:45 -0600 Subject: [PATCH 3/3] ci: run commitlint after installing dependencies Oops. --- .circleci/config.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index c2de6da..a333639 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -170,9 +170,6 @@ workflows: main: jobs: - checkout - - commitlint: - requires: - - checkout - install-dependencies: requires: - checkout @@ -182,6 +179,9 @@ workflows: # - coverage: # requires: # - install-dependencies + - commitlint: + requires: + - install-dependencies - lint: requires: - install-dependencies