From 8263f08c6e172d9b2d650088e056ddc8d0419e54 Mon Sep 17 00:00:00 2001 From: Igor Guastalla de Lima Date: Sun, 3 Mar 2019 20:25:48 -0300 Subject: [PATCH 1/5] fix: fix borders bugs on chrome without breaking in firefox --- scss/utilities/rounded-corners-mixin.scss | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/scss/utilities/rounded-corners-mixin.scss b/scss/utilities/rounded-corners-mixin.scss index 91f1bf9..5b6cfce 100644 --- a/scss/utilities/rounded-corners-mixin.scss +++ b/scss/utilities/rounded-corners-mixin.scss @@ -11,6 +11,18 @@ border-image-source: url('data:image/svg+xml;utf8,'); } +@mixin border-image-chrome() { + @media screen and (-webkit-min-device-pixel-ratio: 0) { + border-image-repeat: space; + } +} + +@mixin border-image-ff() { + @-moz-document url-prefix() { + border-image-repeat: stretch; + } +} + @mixin rounded-corners($isDark: false) { @extend %rounded-corner-defaults; @@ -18,6 +30,9 @@ border-image-width: 3; border-image-repeat: stretch; + @include border-image-chrome(); + @include border-image-ff(); + @if $isDark { @include border-image($color-white); @@ -36,6 +51,9 @@ border-image-width: 2; border-image-repeat: stretch; + @include border-image-chrome(); + @include border-image-ff(); + @if $isDark { @include compact-border-image($color-white); From 4bbb03bee1892a0de0bbbd8cafbdb81fea9153af Mon Sep 17 00:00:00 2001 From: Igor Guastalla de Lima Date: Sun, 3 Mar 2019 20:38:46 -0300 Subject: [PATCH 2/5] fix: changed to media all and add min-resolution --- scss/utilities/rounded-corners-mixin.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scss/utilities/rounded-corners-mixin.scss b/scss/utilities/rounded-corners-mixin.scss index 5b6cfce..5d8a289 100644 --- a/scss/utilities/rounded-corners-mixin.scss +++ b/scss/utilities/rounded-corners-mixin.scss @@ -12,7 +12,7 @@ } @mixin border-image-chrome() { - @media screen and (-webkit-min-device-pixel-ratio: 0) { + @media all and (-webkit-min-device-pixel-ratio: 0) and (min-resolution: .001dpcm) { border-image-repeat: space; } } From 8f60952d9327107dfa50c3a1b274ae14fb4d53e4 Mon Sep 17 00:00:00 2001 From: Igor Guastalla de Lima Date: Mon, 4 Mar 2019 12:26:15 -0300 Subject: [PATCH 3/5] refactor: changed from @-moz-document to @supports -moz-appearance --- scss/utilities/rounded-corners-mixin.scss | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scss/utilities/rounded-corners-mixin.scss b/scss/utilities/rounded-corners-mixin.scss index 5d8a289..10d5b60 100644 --- a/scss/utilities/rounded-corners-mixin.scss +++ b/scss/utilities/rounded-corners-mixin.scss @@ -12,13 +12,13 @@ } @mixin border-image-chrome() { - @media all and (-webkit-min-device-pixel-ratio: 0) and (min-resolution: .001dpcm) { + @media all and (-webkit-min-device-pixel-ratio: 0) and (min-resolution: 0.001dpcm) { border-image-repeat: space; } } @mixin border-image-ff() { - @-moz-document url-prefix() { + @supports (-moz-appearance: meterbar) { border-image-repeat: stretch; } } From c40ae05e85e4c1606ffc43e23f6a8fec6059e3a7 Mon Sep 17 00:00:00 2001 From: Igor Guastalla de Lima Date: Fri, 8 Mar 2019 22:57:21 -0300 Subject: [PATCH 4/5] refactor: changed two mixins into one border-image-repeat mixin --- scss/utilities/rounded-corners-mixin.scss | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/scss/utilities/rounded-corners-mixin.scss b/scss/utilities/rounded-corners-mixin.scss index 10d5b60..3554864 100644 --- a/scss/utilities/rounded-corners-mixin.scss +++ b/scss/utilities/rounded-corners-mixin.scss @@ -11,13 +11,15 @@ border-image-source: url('data:image/svg+xml;utf8,'); } -@mixin border-image-chrome() { +@mixin border-image-repeat() { + border-image-repeat: stretch; + + // for chrome @media all and (-webkit-min-device-pixel-ratio: 0) and (min-resolution: 0.001dpcm) { border-image-repeat: space; } -} -@mixin border-image-ff() { + // for firefox @supports (-moz-appearance: meterbar) { border-image-repeat: stretch; } @@ -30,8 +32,7 @@ border-image-width: 3; border-image-repeat: stretch; - @include border-image-chrome(); - @include border-image-ff(); + @include border-image-repeat(); @if $isDark { @include border-image($color-white); @@ -51,8 +52,7 @@ border-image-width: 2; border-image-repeat: stretch; - @include border-image-chrome(); - @include border-image-ff(); + @include border-image-repeat(); @if $isDark { @include compact-border-image($color-white); From 0aff122be0406af9a43ca6d35723e59203b4c750 Mon Sep 17 00:00:00 2001 From: Igor Guastalla de Lima Date: Fri, 8 Mar 2019 23:19:42 -0300 Subject: [PATCH 5/5] fix: removed border-image-repeat stretch from rounded corners mixins --- scss/utilities/rounded-corners-mixin.scss | 2 -- 1 file changed, 2 deletions(-) diff --git a/scss/utilities/rounded-corners-mixin.scss b/scss/utilities/rounded-corners-mixin.scss index 3554864..608c9bd 100644 --- a/scss/utilities/rounded-corners-mixin.scss +++ b/scss/utilities/rounded-corners-mixin.scss @@ -30,7 +30,6 @@ border-image-slice: 3; border-image-width: 3; - border-image-repeat: stretch; @include border-image-repeat(); @@ -50,7 +49,6 @@ border-image-slice: 2; border-image-width: 2; - border-image-repeat: stretch; @include border-image-repeat();