From 5c1480cd95d7fbe89fc78f7ef82c374e0f8583c4 Mon Sep 17 00:00:00 2001 From: Milos Stojanovic Date: Fri, 6 Sep 2019 11:18:51 +0200 Subject: [PATCH] slow feature tests replaced with unit tests --- tests/backend/Feature/UploadTest.php | 78 ---------------------------- tests/backend/Unit/TmpfsTest.php | 9 +++- 2 files changed, 7 insertions(+), 80 deletions(-) diff --git a/tests/backend/Feature/UploadTest.php b/tests/backend/Feature/UploadTest.php index 0584655..36553ed 100644 --- a/tests/backend/Feature/UploadTest.php +++ b/tests/backend/Feature/UploadTest.php @@ -317,82 +317,4 @@ class UploadTest extends TestCase ], ]); } - - public function testFileUploadWithUTF8() - { - $this->signIn('john@example.com', 'john123'); - - $files = ['file' => new UploadedFile(TEST_FILE, 'ąčęėįšųū.txt', 'text/plain', null, true)]; - - $data = [ - 'resumableChunkNumber' => 1, - 'resumableChunkSize' => 1048576, - 'resumableCurrentChunkSize' => 0.5 * 1024 * 1024, - 'resumableTotalChunks' => 1, - 'resumableTotalSize' => 0.5 * 1024 * 1024, - 'resumableType' => 'text/plain', - 'resumableIdentifier' => 'CHUNKS-SIMPLE-TEST', - 'resumableFilename' => "ąčęėįšųū.txt", - 'resumableRelativePath' => '/', - ]; - - $this->sendRequest('POST', '/upload', $data, $files); - - $this->assertOk(); - - $this->sendRequest('POST', '/getdir', [ - 'dir' => '/', - ]); - - $this->assertResponseJsonHas([ - 'data' => [ - 'files' => [ - 0 => [ - 'type' => 'file', - 'path' => '/ąčęėįšųū.txt', - 'name' => 'ąčęėįšųū.txt', - ], - ], - ], - ]); - } - - public function testFileUploadWithMultibyteName() - { - $this->signIn('john@example.com', 'john123'); - - $files = ['file' => new UploadedFile(TEST_FILE, '断及服务层流.txt', 'text/plain', null, true)]; - - $data = [ - 'resumableChunkNumber' => 1, - 'resumableChunkSize' => 1048576, - 'resumableCurrentChunkSize' => 0.5 * 1024 * 1024, - 'resumableTotalChunks' => 1, - 'resumableTotalSize' => 0.5 * 1024 * 1024, - 'resumableType' => 'text/plain', - 'resumableIdentifier' => 'CHUNKS-SIMPLE-TEST', - 'resumableFilename' => "断及服务层流.txt", - 'resumableRelativePath' => '/', - ]; - - $this->sendRequest('POST', '/upload', $data, $files); - - $this->assertOk(); - - $this->sendRequest('POST', '/getdir', [ - 'dir' => '/', - ]); - - $this->assertResponseJsonHas([ - 'data' => [ - 'files' => [ - 0 => [ - 'type' => 'file', - 'path' => '/断及服务层流.txt', - 'name' => '断及服务层流.txt', - ], - ], - ], - ]); - } } diff --git a/tests/backend/Unit/TmpfsTest.php b/tests/backend/Unit/TmpfsTest.php index 0d20c63..11b7808 100644 --- a/tests/backend/Unit/TmpfsTest.php +++ b/tests/backend/Unit/TmpfsTest.php @@ -146,11 +146,16 @@ class TmpfsTest extends TestCase public function testSanitizeFilename() { + // regular $this->assertEquals('test.txt', $this->invokeMethod($this->service, 'sanitizeFilename', ['test.txt'])); - $this->assertEquals('断及服务层流.txt', $this->invokeMethod($this->service, 'sanitizeFilename', ['断及服务层流.txt'])); + + // utf-8 $this->assertEquals('ąčęėįšųū.txt', $this->invokeMethod($this->service, 'sanitizeFilename', ['ąčęėįšųū.txt'])); - // remove invalid chars + // multi-byte + $this->assertEquals('断及服务层流.txt', $this->invokeMethod($this->service, 'sanitizeFilename', ['断及服务层流.txt'])); + + // with invalid chars $this->assertEquals('..--s-u---pe----rm---an-.t-xt..--', $this->invokeMethod($this->service, 'sanitizeFilename', ["../\\s\"u<:>pe////rm?*|an\\.t\txt../;"])); } }