mirror_php/Faker
1
0
Fork 0
mirror of https://github.com/fzaninotto/Faker.git synced 2025-03-20 23:39:51 +01:00
Code Issues Releases Wiki Activity

make randomElements ~12% faster

Browse Source
This commit is contained in:
David Stensland 2014-03-05 13:36:24 -05:00
parent 6d7f9f4495
commit 176507cc26
1 changed files with 13 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
src/Faker/Provider/Base.php
View File

@ -134,24 +134,29 @@ class Base
*/
public static function randomElements(array $array = array('a', 'b', 'c', 'd', 'e', 'f'), $count = 3)
{
if (count($array) < $count) {
$allKeys = array_keys($array);
$numKeys = count($allKeys);
if ($numKeys < $count) {
throw new \LengthException("Cannot get $count elements, only " . count($array) . ' in array');
}
$keys = array_keys($array);
$highKey = count($keys) - 1;
$highKey = $numKeys - 1;
$keys = $elements = array();
$numElements = 0;
$elements = array();
while ($numElements < $count) {
$key = $keys[mt_rand(0, $highKey)];
if (isset($elements[$key])) {
$key = $allKeys[mt_rand(0, $highKey)];
if (isset($keys[$key])) {
continue;
}
$elements[$key] = $array[$key];
$keys[$key] = true;
$elements[] = $array[$key];
$numElements++;
}
return array_values($elements);
return $elements;
}
/**