From f313ecdeec2f0e44c0cfabba25bfdead60250748 Mon Sep 17 00:00:00 2001
From: Serge Kuharev <sergei.kuharev@stidia.com>
Date: Mon, 2 Jun 2014 19:08:09 +0300
Subject: [PATCH 1/2] Removed non-existing phone format.

---
 src/Faker/Provider/uk_UA/PhoneNumber.php | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/Faker/Provider/uk_UA/PhoneNumber.php b/src/Faker/Provider/uk_UA/PhoneNumber.php
index 1173990a..b18a9b53 100644
--- a/src/Faker/Provider/uk_UA/PhoneNumber.php
+++ b/src/Faker/Provider/uk_UA/PhoneNumber.php
@@ -23,7 +23,6 @@ class PhoneNumber extends \Faker\Provider\PhoneNumber
         '099#######',
 
         // More generic formats
-        '+380#######',
         '+38(0##)#######',
         '+38(0###)######'
     );

From 6ef19503f7362aac8f9eaa7d7161ad38fe542b12 Mon Sep 17 00:00:00 2001
From: Serge Kuharev <sergei.kuharev@stidia.com>
Date: Mon, 2 Jun 2014 19:18:43 +0300
Subject: [PATCH 2/2] Added few tests for uk_UA

---
 test/Faker/Provider/uk_UA/AddressTest.php     | 84 +++++++++++++++++++
 test/Faker/Provider/uk_UA/PhoneNumberTest.php | 37 ++++++++
 2 files changed, 121 insertions(+)
 create mode 100644 test/Faker/Provider/uk_UA/AddressTest.php
 create mode 100644 test/Faker/Provider/uk_UA/PhoneNumberTest.php

diff --git a/test/Faker/Provider/uk_UA/AddressTest.php b/test/Faker/Provider/uk_UA/AddressTest.php
new file mode 100644
index 00000000..3f534a85
--- /dev/null
+++ b/test/Faker/Provider/uk_UA/AddressTest.php
@@ -0,0 +1,84 @@
+<?php
+
+namespace Faker\Test\Provider\uk_UA;
+
+use Faker\Generator;
+use Faker\Provider\uk_UA\Address;
+
+class AddressTest extends \PHPUnit_Framework_TestCase
+{
+
+    /**
+     * @var Generator
+     */
+    private $faker;
+
+    public function setUp()
+    {
+        $faker = new Generator();
+        $faker->addProvider(new Address($faker));
+        $this->faker = $faker;
+    }
+
+    public function testPostCodeIsValid()
+    {
+        $main = '[1-9]{5}';
+        $pattern = "/^($main)|($main-[0-9]{3})+$/";
+        $postcode = $this->faker->postcode;
+        $this->assertSame(
+            preg_match($pattern, $postcode),
+            1,
+            'Post code ' . $postcode . ' is wrong!'
+        );
+    }
+
+    public function testEmptySuffixes()
+    {
+        $this->assertEmpty($this->faker->citySuffix, 'City suffix should be empty!');
+        $this->assertEmpty($this->faker->streetSuffix, 'Street suffix should be empty!');
+    }
+
+    public function testStreetCyrOnly()
+    {
+        $pattern = "/[0-9А-ЩЯІЇЄЮа-щяіїєюьIVXCM][0-9А-ЩЯІЇЄЮа-щяіїєюь \'-.]*[А-Яа-я.]/u";
+        $streetName = $this->faker->streetName;
+        $this->assertSame(
+            preg_match($pattern, $streetName),
+            1,
+            'Street name ' . $streetName . ' is wrong!'
+        );
+    }
+
+    public function testCityNameCyrOnly()
+    {
+        $pattern = "/[А-ЩЯІЇЄЮа-щяіїєюь][0-9А-ЩЯІЇЄЮа-щяіїєюь \'-]*[А-Яа-я]/u";
+        $city = $this->faker->city;
+        $this->assertSame(
+            preg_match($pattern, $city),
+            1,
+            'City name ' . $city . ' is wrong!'
+        );
+    }
+
+    public function testRegionNameCyrOnly()
+    {
+        $pattern = "/[А-ЩЯІЇЄЮ][А-ЩЯІЇЄЮа-щяіїєюь]*а$/u";
+        $regionName = $this->faker->region;
+        $this->assertSame(
+            preg_match($pattern, $regionName),
+            1,
+            'Region name ' . $regionName . ' is wrong!'
+        );
+    }
+
+    public function testCountryCyrOnly()
+    {
+        $pattern = "/[А-ЩЯІЇЄЮа-щяіїєюьIVXCM][А-ЩЯІЇЄЮа-щяіїєюь \'-]*[А-Яа-я.]/u";
+        $country = $this->faker->country;
+        $this->assertSame(
+            preg_match($pattern, $country),
+            1,
+            'Country name ' . $country . ' is wrong!'
+        );
+    }
+}
diff --git a/test/Faker/Provider/uk_UA/PhoneNumberTest.php b/test/Faker/Provider/uk_UA/PhoneNumberTest.php
new file mode 100644
index 00000000..41b41076
--- /dev/null
+++ b/test/Faker/Provider/uk_UA/PhoneNumberTest.php
@@ -0,0 +1,37 @@
+<?php
+
+namespace Faker\Test\Provider\uk_UA;
+
+use Faker\Generator;
+use Faker\Provider\uk_UA\PhoneNumber;
+
+class PhoneNumberTest extends \PHPUnit_Framework_TestCase
+{
+
+    /**
+     * @var Generator
+     */
+    private $faker;
+
+    public function setUp()
+    {
+        $faker = new Generator();
+        $faker->addProvider(new PhoneNumber($faker));
+        $this->faker = $faker;
+    }
+
+    public function testPhoneNumberFormat()
+    {
+        $pattern = "/((\+38)(((\(\d{3}\))\d{7}|(\(\d{4}\))\d{6})|(\d{8})))|0\d{9}/";
+        $phoneNumber = $this->faker->phoneNumber;
+        $this->assertSame(
+            preg_match($pattern, $phoneNumber),
+            1,
+            'Phone number format ' . $phoneNumber . ' is wrong!'
+        );
+
+    }
+
+
+
+}
\ No newline at end of file