From 123b2484704a5fa3864ab79d3c961add9c22fa33 Mon Sep 17 00:00:00 2001 From: cinan Date: Thu, 3 Apr 2014 13:07:31 +0200 Subject: [PATCH 1/3] Missing some letters containing diacritics MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Letter 'ľ' and 'Ľ' were missing --- src/Faker/Provider/sk_SK/Internet.php | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/Faker/Provider/sk_SK/Internet.php b/src/Faker/Provider/sk_SK/Internet.php index 64459ae5..3c883501 100644 --- a/src/Faker/Provider/sk_SK/Internet.php +++ b/src/Faker/Provider/sk_SK/Internet.php @@ -10,14 +10,15 @@ class Internet extends \Faker\Provider\Internet protected static $tld = array('sk', 'sk', 'sk', 'sk', 'sk', 'sk', 'eu', 'com', 'info', 'net', 'org'); /** - * Converts czech characters to their ASCII representation + * Converts czech and slovak characters to their ASCII representation * + * @param string * @return string */ private function toAscii($string) { - $from = array('Ě', 'ě', 'Š', 'š', 'Č', 'č', 'Ř', 'ř', 'Ž', 'ž', 'Ý', 'ý', 'Á', 'á', 'Í', 'í', 'É', 'é', 'Ó', 'ó', 'Ú', 'ú', 'Ů', 'ů', 'Ď', 'ď', 'Ť', 'ť', 'Ň', 'ň'); - $to = array('E', 'e', 'S', 's', 'C', 'c', 'R', 'r', 'Z', 'z', 'Y', 'y', 'A', 'a', 'I', 'i', 'E', 'e', 'O', 'o', 'U', 'u', 'U', 'u', 'D', 'd', 'T', 't', 'N', 'n'); + $from = array('Ě', 'ě', 'Š', 'š', 'Č', 'č', 'Ř', 'ř', 'Ž', 'ž', 'Ý', 'ý', 'Á', 'á', 'Í', 'í', 'É', 'é', 'Ó', 'ó', 'Ú', 'ú', 'Ů', 'ů', 'Ď', 'ď', 'Ť', 'ť', 'Ň', 'ň', 'ľ', 'Ľ'); + $to = array('E', 'e', 'S', 's', 'C', 'c', 'R', 'r', 'Z', 'z', 'Y', 'y', 'A', 'a', 'I', 'i', 'E', 'e', 'O', 'o', 'U', 'u', 'U', 'u', 'D', 'd', 'T', 't', 'N', 'n', 'l', 'l'); return str_replace($from, $to, $string); } From c7efb355823627d8060af9df6912ab2a8a359a17 Mon Sep 17 00:00:00 2001 From: cinan Date: Thu, 3 Apr 2014 13:10:02 +0200 Subject: [PATCH 2/3] FIX: invalid email domain --- src/Faker/Provider/sk_SK/Internet.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Faker/Provider/sk_SK/Internet.php b/src/Faker/Provider/sk_SK/Internet.php index 3c883501..4049e9ef 100644 --- a/src/Faker/Provider/sk_SK/Internet.php +++ b/src/Faker/Provider/sk_SK/Internet.php @@ -5,7 +5,7 @@ namespace Faker\Provider\sk_SK; class Internet extends \Faker\Provider\Internet { - protected static $freeEmailDomain = array('gmail.com', 'yahoo.com', 'zoznam.sk', 'atlas.', 'centrum.sk', 'azet.sk', 'post.sk'); + protected static $freeEmailDomain = array('gmail.com', 'yahoo.com', 'zoznam.sk', 'atlas.sk', 'centrum.sk', 'azet.sk', 'post.sk'); protected static $tld = array('sk', 'sk', 'sk', 'sk', 'sk', 'sk', 'eu', 'com', 'info', 'net', 'org'); From f43733a6ecfd1d94a7d46e1898fe6fb2ce1f2e0d Mon Sep 17 00:00:00 2001 From: cinan Date: Thu, 3 Apr 2014 13:38:45 +0200 Subject: [PATCH 3/3] Missing another letters containing diacritics MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Letter 'ä' and 'Ä' were missing --- src/Faker/Provider/sk_SK/Internet.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Faker/Provider/sk_SK/Internet.php b/src/Faker/Provider/sk_SK/Internet.php index 4049e9ef..d544a1a2 100644 --- a/src/Faker/Provider/sk_SK/Internet.php +++ b/src/Faker/Provider/sk_SK/Internet.php @@ -17,8 +17,8 @@ class Internet extends \Faker\Provider\Internet */ private function toAscii($string) { - $from = array('Ě', 'ě', 'Š', 'š', 'Č', 'č', 'Ř', 'ř', 'Ž', 'ž', 'Ý', 'ý', 'Á', 'á', 'Í', 'í', 'É', 'é', 'Ó', 'ó', 'Ú', 'ú', 'Ů', 'ů', 'Ď', 'ď', 'Ť', 'ť', 'Ň', 'ň', 'ľ', 'Ľ'); - $to = array('E', 'e', 'S', 's', 'C', 'c', 'R', 'r', 'Z', 'z', 'Y', 'y', 'A', 'a', 'I', 'i', 'E', 'e', 'O', 'o', 'U', 'u', 'U', 'u', 'D', 'd', 'T', 't', 'N', 'n', 'l', 'l'); + $from = array('Ě', 'ě', 'Š', 'š', 'Č', 'č', 'Ř', 'ř', 'Ž', 'ž', 'Ý', 'ý', 'Á', 'á', 'Í', 'í', 'É', 'é', 'Ó', 'ó', 'Ú', 'ú', 'Ů', 'ů', 'Ď', 'ď', 'Ť', 'ť', 'Ň', 'ň', 'ľ', 'Ľ', 'ä', 'Ä'); + $to = array('E', 'e', 'S', 's', 'C', 'c', 'R', 'r', 'Z', 'z', 'Y', 'y', 'A', 'a', 'I', 'i', 'E', 'e', 'O', 'o', 'U', 'u', 'U', 'u', 'D', 'd', 'T', 't', 'N', 'n', 'l', 'L', 'a', 'A'); return str_replace($from, $to, $string); }