From a3c149c504d2a066c462b50e380e7ccd5a077d7d Mon Sep 17 00:00:00 2001
From: Kovah <mail@kovah.de>
Date: Sun, 24 Mar 2019 22:05:10 +0100
Subject: [PATCH] Better organize tests

---
 tests/Feature/CategoryCreationTest.php        | 80 -------------------
 tests/Unit/{ => Helper}/LinkaceHelperTest.php |  0
 2 files changed, 80 deletions(-)
 delete mode 100644 tests/Feature/CategoryCreationTest.php
 rename tests/Unit/{ => Helper}/LinkaceHelperTest.php (100%)

diff --git a/tests/Feature/CategoryCreationTest.php b/tests/Feature/CategoryCreationTest.php
deleted file mode 100644
index f5fad177..00000000
--- a/tests/Feature/CategoryCreationTest.php
+++ /dev/null
@@ -1,80 +0,0 @@
-<?php
-
-namespace Tests\Feature;
-
-use App\Http\Controllers\Models\CategoryController;
-use App\Http\Requests\CategoryStoreRequest;
-use App\Models\User;
-use Illuminate\Foundation\Testing\DatabaseMigrations;
-use Illuminate\Foundation\Testing\DatabaseTransactions;
-use Tests\TestCase;
-
-class CategoryCreationTest extends TestCase
-{
-    use DatabaseMigrations;
-    use DatabaseTransactions;
-
-    /** @var User */
-    private $user;
-
-    public function setUp()
-    {
-        parent::setUp();
-
-        $this->user = factory(User::class)->create();
-    }
-
-    /**
-     * A basic test example.
-     *
-     * @return void
-     */
-    public function testValidCategoryCreationRequest()
-    {
-        $data = [
-            '_token' => csrf_token(),
-            'name' => 'Test Category Number 1',
-            'description' => 'Ambitioni dedisse scripsisse iudicaretur',
-            'parent_category' => null,
-            'is_private' => false,
-        ];
-
-        // Create a new request for the category controller
-        // @FIXME This request works but does not use an authenticated user, so the user ID is not available in the controller...
-        $request = new CategoryStoreRequest($data);
-        $controller = new CategoryController();
-        $response = $controller->store($request);
-
-        // Assert that a redirect is performed
-        $this->assertEquals(302, $response->getStatusCode());
-
-        // Assert that the database now has a category called 'Test Category Number 1'
-        $this->assertDatabaseHas('categories', [
-            'name' => 'Test Category Number 1',
-        ]);
-    }
-
-    /**
-     * A basic test example.
-     *
-     * @return void
-     */
-    public function testInvalidCategoryCreationRequest()
-    {
-        $data = [
-            '_token' => csrf_token(),
-            'name' => null,
-            'description' => null,
-            'parent_category' => null,
-            'is_private' => false,
-        ];
-
-        // Create a new request for the category controller
-        // @FIXME This approach returns a 422 error (Unprocessable Entity)?
-        $response = $this->actingAs($this->user)
-            ->call('POST', route('categories.store'), $data);
-
-        // Assert that a redirect is performed
-        $this->assertEquals(302, $response->getStatusCode());
-    }
-}
diff --git a/tests/Unit/LinkaceHelperTest.php b/tests/Unit/Helper/LinkaceHelperTest.php
similarity index 100%
rename from tests/Unit/LinkaceHelperTest.php
rename to tests/Unit/Helper/LinkaceHelperTest.php