mirror_php/PHP-Parser
1
0
Fork 0
mirror of https://github.com/nikic/PHP-Parser.git synced 2025-01-17 15:18:17 +01:00
Code Issues Packages Projects Releases Wiki Activity

Ensure removing visitor does not leave holes

Browse Source
This commit is contained in:
Nikita Popov 2023-05-21 12:07:21 +02:00
parent fb2c3ac97c
commit 8bc698248d
2 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
lib/PhpParser/NodeTraverser.php
View File

@ -48,11 +48,9 @@ class NodeTraverser implements NodeTraverserInterface {
* @param NodeVisitor $visitor
*/
public function removeVisitor(NodeVisitor $visitor): void {
foreach ($this->visitors as $index => $storedVisitor) {
if ($storedVisitor === $visitor) {
unset($this->visitors[$index]);
break;
}
$index = array_search($visitor, $this->visitors);
if ($index !== false) {
array_splice($this->visitors, $index, 1, []);
}
}

2
test/PhpParser/NodeTraverserTest.php
View File

@ -348,7 +348,7 @@ class NodeTraverserTest extends \PHPUnit\Framework\TestCase {
$traverser->removeVisitor($visitor2);
$postExpected = [0 => $visitor1, 2 => $visitor3];
$postExpected = [$visitor1, $visitor3];
$this->assertSame($postExpected, $getVisitors());
}