mirror_php/PHP-Parser
1
0
Fork 0
mirror of https://github.com/nikic/PHP-Parser.git synced 2025-01-16 22:58:15 +01:00
Code Issues Packages Projects Releases Wiki Activity

Avoid by-reference iteration in NodeTraverser

Browse Source 
No need to create reference wrappers around every element in the
array.
This commit is contained in:
Nikita Popov 2023-09-26 20:25:37 +02:00
parent b4183c2b09
commit de84f76766
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lib/PhpParser/NodeTraverser.php
View File

@ -175,7 +175,7 @@ class NodeTraverser implements NodeTraverserInterface {
protected function traverseArray(array $nodes): array {
$doNodes = [];
foreach ($nodes as $i => &$node) {
foreach ($nodes as $i => $node) {
if ($node instanceof Node) {
$traverseChildren = true;
$visitorIndex = -1;
@ -185,7 +185,7 @@ class NodeTraverser implements NodeTraverserInterface {
if (null !== $return) {
if ($return instanceof Node) {
$this->ensureReplacementReasonable($node, $return);
$node = $return;
$nodes[$i] = $node = $return;
} elseif (\is_array($return)) {
$doNodes[] = [$i, $return];
continue 2;
@ -225,7 +225,7 @@ class NodeTraverser implements NodeTraverserInterface {
if (null !== $return) {
if ($return instanceof Node) {
$this->ensureReplacementReasonable($node, $return);
$node = $return;
$nodes[$i] = $node = $return;
} elseif (\is_array($return)) {
$doNodes[] = [$i, $return];
break;