Fix impossibility to set empty password via askHiddenResponse() (#2319)

* Fix impossibility to set empty password via askHiddenResponse()

* Update CHANGELOG.md

* Update CHANGELOG.md
This commit is contained in:
TrueXakeP 2020-12-03 11:24:46 +02:00 committed by GitHub
parent b4d3d27a7d
commit 9a48ed0561
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 2 deletions

View File

@ -31,6 +31,7 @@
### Fixed
- Lots, and lots of long-standing bugs.
- Impossibility to ask for empty password via askHiddenResponse(). [#2317]
## v6.8.0
@ -595,6 +596,7 @@
- Fixed `DotArray` syntax in `Collection`.
[#2317]: https://github.com/deployphp/deployer/issues/2317
[#2197]: https://github.com/deployphp/deployer/issues/2197
[#1994]: https://github.com/deployphp/deployer/issues/1994
[#1990]: https://github.com/deployphp/deployer/issues/1990

View File

@ -740,7 +740,7 @@ function askHiddenResponse(string $message): string
}
if (Deployer::isWorker()) {
return Deployer::proxyCallToMaster(currentHost(), __FUNCTION__, ...func_get_args());
return (string) Deployer::proxyCallToMaster(currentHost(), __FUNCTION__, ...func_get_args());
}
/** @var QuestionHelper */
@ -753,7 +753,7 @@ function askHiddenResponse(string $message): string
$question->setHidden(true);
$question->setHiddenFallback(false);
return $helper->ask(input(), output(), $question);
return (string) $helper->ask(input(), output(), $question);
}
function input(): InputInterface