In the "Upgrade from 4.x to 5.x," section,
previously, the suggested mapping for `server($name, $hostname)` to `host($hostname)` silently dropped the $name, which will not retain the same command line calling argument.
There's no need to drop the $name, moving from 4.x to 5.x just changes the way it's declared. So this PR adds more precise suggested mapping, so that users will have smoother transition when upgrading.
* add test to show issue with once() used with --parallel and --limit issue
* handle once() in a better way to prevent issue with --parallel and --limit
* Add test before http_user detection
Script will no attempt to longer detect http_user if there are more than 1 possible candidates.
* Update CHANGELOG.md
Updated for issue #1778
* Update CHANGELOG.md
Added missing link to issue
* Change detection strategy from bash test to php
This reduces the number of ssh calls to the remote host.
* Let rsync honor 'become' option for host
If a host has a 'become' option set, it seems sensible that rsync uploads
should also be performed as that same user, which is currently not the case.
This change makes rsync run as the 'become' user by running sudo on the
remote side, just like how 'become' is implemented for normal SSH commands.
* Update CHANGELOG.md
* Update CHANGELOG.md
* Escape arguments passed to rsync shell command
This fixes errors when attempting to upload a path containing spaces.
* Update CHANGELOG.md
* Update CHANGELOG.md
* Update missing argument in PHPDoc.
* Splits the IF-statement/workflow(s) for readability
* Replace double quotes to single quotes.
* Replaced alias functions by original functions.
* Define return types.
* Type casting can be used
* Non-optimal regular expression, \d is a subset of \w.
* Fix header merge
We should use array_merge to append and reindex header array, + causes an issue where if we add a header, like for example Authorization, then the first item in merged header will be skipped (Content-Type) as there will already be a header at 0 index of array. + does not replace values which keys already exist in arrays
* Update CHANGELOG.md