mirror_php/formwork
1
0
Fork 0
mirror of https://github.com/getformwork/formwork.git synced 2025-03-14 19:19:48 +01:00
Code Issues Packages Projects Releases Wiki Activity

Remove superfluous checks before foreach

Browse Source
This commit is contained in:
Giuseppe Criscione 2020-11-26 16:46:15 +01:00
parent 026cce18b2
commit ac8b8bce6e
4 changed files with 13 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
admin/src/Controllers/Pages.php
View File

@ -508,16 +508,14 @@ class Pages extends AbstractController
$uploader->upload();
$page->reload();
if (!empty($uploader->uploadedFiles())) {
foreach ($uploader->uploadedFiles() as $file) {
$file = $page->files()->get($file);
foreach ($uploader->uploadedFiles() as $file) {
$file = $page->files()->get($file);
// Process JPEG and PNG images according to system options (e.g. quality)
if ($this->option('images.process_uploads') && in_array($file->mimeType(), ['image/jpeg', 'image/png'], true)) {
$image = new Image($file->path());
$image->saveOptimized();
$page->reload();
}
// Process JPEG and PNG images according to system options (e.g. quality)
if ($this->option('images.process_uploads') && in_array($file->mimeType(), ['image/jpeg', 'image/png'], true)) {
$image = new Image($file->path());
$image->saveOptimized();
$page->reload();
}
}
}

6
admin/src/Updater.php
View File

@ -208,10 +208,8 @@ class Updater
if ($this->options['cleanupAfterInstall']) {
$deletableFiles = $this->findDeletableFiles($installedFiles);
if (!empty($deletableFiles)) {
foreach ($deletableFiles as $file) {
FileSystem::delete($file);
}
foreach ($deletableFiles as $file) {
FileSystem::delete($file);
}
}

6
formwork/Core/Page.php
View File

@ -608,10 +608,8 @@ class Page extends AbstractPage
if ($this->has('response_status')) {
Header::status((int) $this->get('response_status'));
}
if (!empty($this->headers())) {
foreach ($this->headers() as $name => $value) {
Header::send($name, $value);
}
foreach ($this->headers() as $name => $value) {
Header::send($name, $value);
}
}

6
formwork/Core/Response.php
View File

@ -78,10 +78,8 @@ class Response
{
$this->sendStatus();
if (!empty($this->headers)) {
foreach ($this->headers as $fieldName => $fieldValue) {
Header::send($fieldName, $fieldValue);
}
foreach ($this->headers as $fieldName => $fieldValue) {
Header::send($fieldName, $fieldValue);
}
}