From e6f837a9a888073223eb0bab5c74b4d1784d3a60 Mon Sep 17 00:00:00 2001 From: Curtis Farnham Date: Wed, 31 Jan 2018 12:46:25 -0800 Subject: [PATCH] Error with malformed domain that contains a "/" --- src/Cookie/SetCookie.php | 2 +- tests/Cookie/SetCookieTest.php | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/src/Cookie/SetCookie.php b/src/Cookie/SetCookie.php index ddb819b2..7b158b0a 100644 --- a/src/Cookie/SetCookie.php +++ b/src/Cookie/SetCookie.php @@ -348,7 +348,7 @@ class SetCookie return false; } - return (bool) preg_match('/\.' . preg_quote($cookieDomain) . '$/', $domain); + return (bool) preg_match('/\.' . preg_quote($cookieDomain, '/') . '$/', $domain); } /** diff --git a/tests/Cookie/SetCookieTest.php b/tests/Cookie/SetCookieTest.php index 71ff3943..fb401350 100644 --- a/tests/Cookie/SetCookieTest.php +++ b/tests/Cookie/SetCookieTest.php @@ -115,6 +115,9 @@ class SetCookieTest extends \PHPUnit_Framework_TestCase $cookie->setDomain('.local'); $this->assertTrue($cookie->matchesDomain('example.local')); + + $cookie->setDomain('example.com/'); // malformed domain + $this->assertFalse($cookie->matchesDomain('example.com')); } public function pathMatchProvider()