mirror_php/humhub
1
0
Fork 0
mirror of https://github.com/humhub/humhub.git synced 2025-02-12 03:26:25 +01:00
Code Issues Projects Releases Wiki Activity

Merge pull request #4176 from humhub/enh/3990

Browse Source 
Enh #3990: Use StrictAccess by default in humhub\components\Controller
This commit is contained in:
Lucas Bartholemy 2020-07-08 10:42:14 +02:00 committed by GitHub
commit 290ed16713
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
11 changed files with 71 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
protected/humhub/components/Controller.php
View File

@ -9,6 +9,7 @@
namespace humhub\components;
use humhub\components\access\ControllerAccess;
use humhub\components\access\StrictAccess;
use humhub\components\behaviors\AccessControl;
use Yii;
use yii\helpers\Url;
@ -56,7 +57,7 @@ class Controller extends \yii\web\Controller
* @var string defines the ControllerAccess class for this controller responsible for managing access rules
* @see self::getAccess()
*/
protected $access = ControllerAccess::class;
protected $access = StrictAccess::class;
/**
* Returns access rules for the standard access control behavior.
@ -70,7 +71,7 @@ class Controller extends \yii\web\Controller
}
/**
* @return null|ControllerAccess returns an ControllerAccess instance
* @return null|ControllerAccess returns a ControllerAccess instance
*/
public function getAccess()
{

6
protected/humhub/modules/activity/controllers/LinkController.php
View File

@ -9,7 +9,6 @@
namespace humhub\modules\activity\controllers;
use Yii;
use humhub\components\access\StrictAccess;
use humhub\components\Controller;
use humhub\modules\activity\models\Activity;
use yii\web\HttpException;
@ -22,11 +21,6 @@ use yii\web\HttpException;
class LinkController extends Controller
{
/**
* @inheritdoc
*/
public $access = StrictAccess::class;
/**
* Returns the link for the given activity.
*/

7
protected/humhub/modules/installer/controllers/ConfigController.php
View File

@ -8,6 +8,7 @@
namespace humhub\modules\installer\controllers;
use humhub\components\access\ControllerAccess;
use humhub\components\Controller;
use humhub\modules\marketplace\Module;
use humhub\modules\queue\driver\Sync;
@ -29,6 +30,12 @@ use yii\base\InvalidConfigException;
*/
class ConfigController extends Controller
{
/**
* Allow guest access independently from guest mode setting.
*
* @var string
*/
public $access = ControllerAccess::class;
const EVENT_INSTALL_SAMPLE_DATA = 'install_sample_data';

7
protected/humhub/modules/installer/controllers/IndexController.php
View File

@ -9,6 +9,7 @@
namespace humhub\modules\installer\controllers;
use humhub\components\access\ControllerAccess;
use humhub\components\Controller;
@ -19,6 +20,12 @@ use humhub\components\Controller;
*/
class IndexController extends Controller
{
/**
* Allow guest access independently from guest mode setting.
*
* @var string
*/
public $access = ControllerAccess::class;
/**
* Index View just provides a welcome page

8
protected/humhub/modules/installer/controllers/SetupController.php
View File

@ -8,6 +8,7 @@
namespace humhub\modules\installer\controllers;
use humhub\components\access\ControllerAccess;
use Yii;
use humhub\components\Controller;
use humhub\modules\installer\forms\DatabaseForm;
@ -22,6 +23,13 @@ use humhub\modules\admin\widgets\PrerequisitesList;
*/
class SetupController extends Controller
{
/**
* Allow guest access independently from guest mode setting.
*
* @var string
*/
public $access = ControllerAccess::class;
const PASSWORD_PLACEHOLDER = 'n0thingToSeeHere!';

8
protected/humhub/modules/user/controllers/AuthController.php
View File

@ -8,6 +8,7 @@
namespace humhub\modules\user\controllers;
use humhub\components\access\ControllerAccess;
use humhub\components\Controller;
use humhub\modules\user\models\User;
use humhub\modules\user\authclient\AuthAction;
@ -40,6 +41,13 @@ class AuthController extends Controller
*/
public $layout = '@humhub/modules/user/views/layouts/main';
/**
* Allow guest access independently from guest mode setting.
*
* @var string
*/
public $access = ControllerAccess::class;
/**
* @inheritdoc
*/

8
protected/humhub/modules/user/controllers/PasswordRecoveryController.php
View File

@ -8,6 +8,7 @@
namespace humhub\modules\user\controllers;
use humhub\components\access\ControllerAccess;
use Yii;
use yii\web\HttpException;
use humhub\components\Controller;
@ -28,6 +29,13 @@ class PasswordRecoveryController extends Controller
*/
public $layout = "@humhub/modules/user/views/layouts/main";
/**
* Allow guest access independently from guest mode setting.
*
* @var string
*/
public $access = ControllerAccess::class;
/**
* @inheritdoc
*/

8
protected/humhub/modules/user/controllers/RegistrationController.php
View File

@ -8,6 +8,7 @@
namespace humhub\modules\user\controllers;
use humhub\components\access\ControllerAccess;
use Yii;
use yii\base\Exception;
use yii\web\HttpException;
@ -31,6 +32,13 @@ class RegistrationController extends Controller
*/
public $layout = "@humhub/modules/user/views/layouts/main";
/**
* Allow guest access independently from guest mode setting.
*
* @var string
*/
public $access = ControllerAccess::class;
/**
* @inheritdoc
* @throws HttpException

7
protected/humhub/modules/web/pwa/controllers/ManifestController.php
View File

@ -8,6 +8,7 @@
namespace humhub\modules\web\pwa\controllers;
use humhub\components\access\ControllerAccess;
use humhub\components\Controller;
use humhub\modules\web\pwa\widgets\SiteIcon;
use humhub\modules\web\Module;
@ -24,6 +25,12 @@ use yii\helpers\Url;
*/
class ManifestController extends Controller
{
/**
* Allow guest access independently from guest mode setting.
*
* @var string
*/
public $access = ControllerAccess::class;
/**
* @var array the manifest

8
protected/humhub/modules/web/pwa/controllers/OfflineController.php
View File

@ -8,6 +8,7 @@
namespace humhub\modules\web\pwa\controllers;
use humhub\components\access\ControllerAccess;
use humhub\components\Controller;
use humhub\modules\ui\Module;
@ -20,6 +21,13 @@ use humhub\modules\ui\Module;
*/
class OfflineController extends Controller
{
/**
* Allow guest access independently from guest mode setting.
*
* @var string
*/
public $access = ControllerAccess::class;
public function actionIndex()
{
return $this->renderPartial('@humhub/modules/web/pwa/views/offline/index');

8
protected/humhub/modules/web/pwa/controllers/ServiceWorkerController.php
View File

@ -8,6 +8,7 @@
namespace humhub\modules\web\pwa\controllers;
use humhub\components\access\ControllerAccess;
use humhub\components\Controller;
use humhub\modules\ui\Module;
use Yii;
@ -23,7 +24,12 @@ use yii\helpers\Url;
*/
class ServiceWorkerController extends Controller
{
/**
* Allow guest access independently from guest mode setting.
*
* @var string
*/
public $access = ControllerAccess::class;
public $baseJs;
public $additionalJs;