Fix #4703: SSO login drops no warning if AuthClient cannot be stored (#4704)

This commit is contained in:
Lucas Bartholemy 2020-12-30 16:09:54 +01:00 committed by GitHub
parent 041057e037
commit 4c4d5ca169
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 2 deletions

View File

@ -5,6 +5,7 @@ HumHub Changelog
-------------------------
- Fix #4668: table-responsive tables do not overflow due to default word break style
- Fix #4679: Richtext extension scan does not include full title if title contains a `)`
- Fix #4703: SSO login drops no warning if AuthClient cannot be stored
- Fix #4700: Deep Links from Microsoft Office Documents
- Fix #4714: Use HTTPS protocol for default OEmbed endpoint URLs
- Fix #4727: Nav tabs with data-toggle are styled in link color

View File

@ -61,7 +61,7 @@ class AuthClientHelpers
if ($authClient instanceof interfaces\PrimaryClient) {
$user->auth_mode = $authClient->getId();
$user->save();
} elseif (isset($attributes['id'])) {
} elseif (!empty($attributes['id'])) {
$auth = Auth::findOne(['source' => $authClient->getId(), 'source_id' => $attributes['id']]);
/**
@ -72,7 +72,6 @@ class AuthClientHelpers
$auth = null;
}
if ($auth === null) {
$auth = new Auth([
'user_id' => $user->id,