From e6b81cd6d20b1162bc2f35c6f3e9cede6f184b82 Mon Sep 17 00:00:00 2001
From: buddh4 <mail@jharrer.de>
Date: Mon, 30 Nov 2020 18:08:43 +0100
Subject: [PATCH] Fix: Richtext extension scan cuts title if title contains `)`

---
 .../unit/RichtextExtensionTest.php            | 54 +++++++++++++++++++
 .../widgets/richtext/ProsemirrorRichText.php  |  4 +-
 2 files changed, 56 insertions(+), 2 deletions(-)
 create mode 100644 protected/humhub/modules/content/tests/codeception/unit/RichtextExtensionTest.php

diff --git a/protected/humhub/modules/content/tests/codeception/unit/RichtextExtensionTest.php b/protected/humhub/modules/content/tests/codeception/unit/RichtextExtensionTest.php
new file mode 100644
index 0000000000..f555dcca74
--- /dev/null
+++ b/protected/humhub/modules/content/tests/codeception/unit/RichtextExtensionTest.php
@@ -0,0 +1,54 @@
+<?php
+
+
+namespace humhub\modules\content\tests\codeception\unit;
+
+
+use humhub\modules\content\widgets\richtext\ProsemirrorRichText;
+use tests\codeception\_support\HumHubDbTestCase;
+
+class RichtextExtensionTest extends HumHubDbTestCase
+{
+    public function testStripHtml()
+    {
+        $text = '[img3.jpg](http://humhub.com "img)3.jpg" xasdfjpös0as) 
+
+[test2.txt](file-guid:aef0eb95-b715-4707-9792-180e4395e681)
+
+test
+![img3.jpg](file-guid:3f1e14a2-4375-434a-a554-a19ec5e48909 "img))))3.jpg")asdfas
+asdfasdfasdf
+
+[test2.txt](file-guid:aef0eb95-b715-4707-9792-180e4395e681 "test")
+
+asdfasdfasdf
+
+[test2.txt](file-guid:aef0eb95-b715-4707-9792-180e4395e681)';
+
+        $matches = ProsemirrorRichText::scanLinkExtension($text, 'file-guid');
+
+        static::assertCount(4, $matches);
+
+        static::assertEquals('[test2.txt](file-guid:aef0eb95-b715-4707-9792-180e4395e681)', $matches[0][0]);
+        static::assertEquals('test2.txt', $matches[0][1]);
+        static::assertEquals('file-guid', $matches[0][2]);
+        static::assertEquals('aef0eb95-b715-4707-9792-180e4395e681', $matches[0][3]);
+
+        static::assertEquals('[img3.jpg](file-guid:3f1e14a2-4375-434a-a554-a19ec5e48909 "img))))3.jpg")', $matches[1][0]);
+        static::assertEquals('img3.jpg', $matches[1][1]);
+        static::assertEquals('file-guid', $matches[1][2]);
+        static::assertEquals('3f1e14a2-4375-434a-a554-a19ec5e48909', $matches[1][3]);
+        static::assertEquals('img))))3.jpg', $matches[1][4]);
+
+        static::assertEquals('[test2.txt](file-guid:aef0eb95-b715-4707-9792-180e4395e681 "test")', $matches[2][0]);
+        static::assertEquals('test2.txt', $matches[2][1]);
+        static::assertEquals('file-guid', $matches[2][2]);
+        static::assertEquals('aef0eb95-b715-4707-9792-180e4395e681', $matches[2][3]);
+        static::assertEquals('test', $matches[2][4]);
+
+        static::assertEquals('[test2.txt](file-guid:aef0eb95-b715-4707-9792-180e4395e681)', $matches[3][0]);
+        static::assertEquals('test2.txt', $matches[3][1]);
+        static::assertEquals('file-guid', $matches[3][2]);
+        static::assertEquals('aef0eb95-b715-4707-9792-180e4395e681', $matches[3][3]);
+    }
+}
diff --git a/protected/humhub/modules/content/widgets/richtext/ProsemirrorRichText.php b/protected/humhub/modules/content/widgets/richtext/ProsemirrorRichText.php
index 2164e164d7..db98875a13 100644
--- a/protected/humhub/modules/content/widgets/richtext/ProsemirrorRichText.php
+++ b/protected/humhub/modules/content/widgets/richtext/ProsemirrorRichText.php
@@ -292,10 +292,10 @@ class ProsemirrorRichText extends AbstractRichText
     protected static function getLinkExtensionPattern($extension = '[a-zA-Z]+')
     {
         if($extension === null) {
-            $extension  = '[a-zA-Z]+';
+            $extension  = '[a-zA-Z-_]+';
         }
 
-        return '/(?<!\\\\)\[([^\]]*)\]\(('.$extension.'):{1}([^\)\s]*)(?:\s")?([^")]*)?(?:")?[^\)]*\)/is';
+        return '/(?<!\\\\)\[([^\]]*)\]\(('.$extension.'):{1}([^\)\s]*)(?:\s)?(?:"([^"]*)")?[^\)]*\)/is';
     }
 
     /**