Some more cleanup

This commit is contained in:
Matthias Mullie 2022-11-17 13:53:25 +01:00
parent 9bb6c1c226
commit bc915c8eb0
5 changed files with 15 additions and 6 deletions

5
.gitattributes vendored
View File

@ -1,9 +1,12 @@
* text=auto
/.github export-ignore
/tests export-ignore
/.gitattributes export-ignore
/.gitignore export-ignore
/appveyor.yml export-ignore
/.php-cs-fixer.php export-ignore
/CONTRIBUTING.md export-ignore
/Dockerfile export-ignore
/makefile export-ignore
/phpunit.xml export-ignore
/README.md export-ignore

View File

@ -41,8 +41,7 @@ to run php-cs-fixer before submitting the code, it'll take care of the
formatting for you:
```sh
vendor/bin/php-cs-fixer fix src
vendor/bin/php-cs-fixer fix tests
make php-cs-fixer
```
Document the code thoroughly!

View File

@ -1,4 +1,4 @@
PHP ?= 8.1
PHP ?=
TEST ?=
docs:
@ -7,7 +7,12 @@ docs:
php phpDocumentor.phar --directory=src --target=docs --visibility=public --defaultpackagename=Minify --title=Minify;"
test:
docker build -t matthiasmullie/minify:$(PHP) . --build-arg VERSION=$(PHP)-cli
docker run -v $$(pwd)/build:/var/www/build matthiasmullie/minify:$(PHP) env XDEBUG_MODE=coverage vendor/bin/phpunit $(TEST) --coverage-clover build/coverage-$(PHP)-$(TEST).clover
VERSION=$$(echo "$(PHP)-cli" | sed "s/^-//");\
test $$(docker images -q matthiasmullie/minify:$$VERSION) || docker build -t matthiasmullie/minify:$$VERSION . --build-arg VERSION=$$VERSION;\
docker run -v $$(pwd)/src:/var/www/src -v $$(pwd)/tests:/var/www/tests -v $$(pwd)/build:/var/www/build matthiasmullie/minify:$$VERSION env XDEBUG_MODE=coverage vendor/bin/phpunit $(TEST) --coverage-clover build/coverage-$(PHP)-$(TEST).clover
php-cs-fixer:
test $$(docker images -q matthiasmullie/minify:cli) || docker build -t matthiasmullie/minify:cli .
docker run -v $$(pwd)/src:/var/www/src -v $$(pwd)/tests:/var/www/tests matthiasmullie/minify:cli vendor/bin/php-cs-fixer fix
.PHONY: docs

File diff suppressed because one or more lines are too long

View File

@ -45,6 +45,7 @@ abstract class Minify
* without having to worry about potential "code-like" characters inside.
*
* @internal
*
* @var string[]
*/
public $extracted = array();