2020-03-27 23:07:28 +11:00
|
|
|
<?php
|
|
|
|
// This file is part of Moodle - http://moodle.org/
|
|
|
|
//
|
|
|
|
// Moodle is free software: you can redistribute it and/or modify
|
|
|
|
// it under the terms of the GNU General Public License as published by
|
|
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
|
|
// (at your option) any later version.
|
|
|
|
//
|
|
|
|
// Moodle is distributed in the hope that it will be useful,
|
|
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
|
|
// GNU General Public License for more details.
|
|
|
|
//
|
|
|
|
// You should have received a copy of the GNU General Public License
|
|
|
|
// along with Moodle. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
|
MDL-75111 phpunit: Move tests to use correct names and ns (take#4)
Applied the following changes to various testcase classes:
- Namespaced with component[\level2-API]
- Moved to level2-API subdirectory when required.
- Fixed incorrect use statements with leading backslash.
- Remove file phpdoc block
- Remove MOODLE_INTERNAL if not needed.
- Changed code to point to global scope when needed.
- Fix some relative paths and comments here and there.
- All them passing individually.
- Complete runs passing too.
Special mention to:
- The following task tests have been moved within the level2 directory:
- \core\adhoc_task_test => \core\task\adhoc_task_test
- \core\scheduled_task_test => \core\task\scheduled_task_test
- \core\calendar_cron_task_test => \core\task\calendar_cron_task_test
- \core\h5p_get_content_types_task_test => \core\task\h5p_get_content_types_task_test
- \core\task_database_logger_test => \core\task\database_logger_test
- \core\task_logging_test => \core\task\logging_test
- The following event tests have been moved within level2 directory:
- \core\event_context_locked_test => \core\event\context_locked_test
- \core\event_deprecated_test => \core\event\deprecated_test
- \core\event_grade_deleted_test => \core\event\grade_deleted_test
- \core\event_profile_field_test => \core\event\profile_field_test
- \core\event_unknown_logged_test => \core\event\unknown_logged_test
- \core\event_user_graded_test => \core\event\user_graded_test
- \core\event_user_password_updated_test => \core\event\user_password_updated_test
- The following output tests have been moved within level2 directory:
- \core\mustache_template_finder_test => \core\output\mustache_template_finder_test
- \core\mustache_template_source_loader_test => \core\output\mustache_template_source_loader_test
- \core\output_mustache_helper_collection_test => \core\output\mustache_helper_collection_test
- The following tests have been moved to their correct tests directories:
- lib/tests/time_splittings_test.php => analytics/tests/time_splittings_test.php
- All the classes and tests under lib/filebrowser and lib/filestorage
belong to core, not to core_files. Some day we should move
them to their correct subsystem.
- All the classes and tests under lib/grade belong to core, not
to core_grades. Some day we should move them to their correct
subsystem.
- The core_grades_external class and its \core\grades_external_test
unit test should belong to the grades subsystem or, alternatively,
to \core\external, they both should be moved together.
- The core_grading_external class and its \core\grading_external_test
unit test should belong to the grading subsystem or, alternatively,
to \core\external, they both should be moved together.
- The \core\message\message and \core\message\inbound (may be others)
classes, and their associated tests should go to the core_message
subsystem.
- The core_user class, and its associated tests should go to the
core_user subsystem.
- The \core\update namespace is plain wrong (update is not valid API)
and needs action 1) create it or 2) move elsewhere.
2022-07-01 16:43:34 +02:00
|
|
|
namespace core;
|
2020-03-27 23:07:28 +11:00
|
|
|
|
|
|
|
defined('MOODLE_INTERNAL') || die();
|
|
|
|
|
|
|
|
global $CFG;
|
|
|
|
require_once($CFG->libdir.'/adminlib.php');
|
|
|
|
|
|
|
|
/**
|
|
|
|
* Unit tests for parts of adminlib.php.
|
|
|
|
*
|
MDL-75111 phpunit: Move tests to use correct names and ns (take#4)
Applied the following changes to various testcase classes:
- Namespaced with component[\level2-API]
- Moved to level2-API subdirectory when required.
- Fixed incorrect use statements with leading backslash.
- Remove file phpdoc block
- Remove MOODLE_INTERNAL if not needed.
- Changed code to point to global scope when needed.
- Fix some relative paths and comments here and there.
- All them passing individually.
- Complete runs passing too.
Special mention to:
- The following task tests have been moved within the level2 directory:
- \core\adhoc_task_test => \core\task\adhoc_task_test
- \core\scheduled_task_test => \core\task\scheduled_task_test
- \core\calendar_cron_task_test => \core\task\calendar_cron_task_test
- \core\h5p_get_content_types_task_test => \core\task\h5p_get_content_types_task_test
- \core\task_database_logger_test => \core\task\database_logger_test
- \core\task_logging_test => \core\task\logging_test
- The following event tests have been moved within level2 directory:
- \core\event_context_locked_test => \core\event\context_locked_test
- \core\event_deprecated_test => \core\event\deprecated_test
- \core\event_grade_deleted_test => \core\event\grade_deleted_test
- \core\event_profile_field_test => \core\event\profile_field_test
- \core\event_unknown_logged_test => \core\event\unknown_logged_test
- \core\event_user_graded_test => \core\event\user_graded_test
- \core\event_user_password_updated_test => \core\event\user_password_updated_test
- The following output tests have been moved within level2 directory:
- \core\mustache_template_finder_test => \core\output\mustache_template_finder_test
- \core\mustache_template_source_loader_test => \core\output\mustache_template_source_loader_test
- \core\output_mustache_helper_collection_test => \core\output\mustache_helper_collection_test
- The following tests have been moved to their correct tests directories:
- lib/tests/time_splittings_test.php => analytics/tests/time_splittings_test.php
- All the classes and tests under lib/filebrowser and lib/filestorage
belong to core, not to core_files. Some day we should move
them to their correct subsystem.
- All the classes and tests under lib/grade belong to core, not
to core_grades. Some day we should move them to their correct
subsystem.
- The core_grades_external class and its \core\grades_external_test
unit test should belong to the grades subsystem or, alternatively,
to \core\external, they both should be moved together.
- The core_grading_external class and its \core\grading_external_test
unit test should belong to the grading subsystem or, alternatively,
to \core\external, they both should be moved together.
- The \core\message\message and \core\message\inbound (may be others)
classes, and their associated tests should go to the core_message
subsystem.
- The core_user class, and its associated tests should go to the
core_user subsystem.
- The \core\update namespace is plain wrong (update is not valid API)
and needs action 1) create it or 2) move elsewhere.
2022-07-01 16:43:34 +02:00
|
|
|
* @package core
|
2020-03-27 23:07:28 +11:00
|
|
|
* @copyright 2020 Brendan Heywood <brendan@catalyst-au.net>
|
|
|
|
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
|
|
|
|
*/
|
MDL-75111 phpunit: Move tests to use correct names and ns (take#4)
Applied the following changes to various testcase classes:
- Namespaced with component[\level2-API]
- Moved to level2-API subdirectory when required.
- Fixed incorrect use statements with leading backslash.
- Remove file phpdoc block
- Remove MOODLE_INTERNAL if not needed.
- Changed code to point to global scope when needed.
- Fix some relative paths and comments here and there.
- All them passing individually.
- Complete runs passing too.
Special mention to:
- The following task tests have been moved within the level2 directory:
- \core\adhoc_task_test => \core\task\adhoc_task_test
- \core\scheduled_task_test => \core\task\scheduled_task_test
- \core\calendar_cron_task_test => \core\task\calendar_cron_task_test
- \core\h5p_get_content_types_task_test => \core\task\h5p_get_content_types_task_test
- \core\task_database_logger_test => \core\task\database_logger_test
- \core\task_logging_test => \core\task\logging_test
- The following event tests have been moved within level2 directory:
- \core\event_context_locked_test => \core\event\context_locked_test
- \core\event_deprecated_test => \core\event\deprecated_test
- \core\event_grade_deleted_test => \core\event\grade_deleted_test
- \core\event_profile_field_test => \core\event\profile_field_test
- \core\event_unknown_logged_test => \core\event\unknown_logged_test
- \core\event_user_graded_test => \core\event\user_graded_test
- \core\event_user_password_updated_test => \core\event\user_password_updated_test
- The following output tests have been moved within level2 directory:
- \core\mustache_template_finder_test => \core\output\mustache_template_finder_test
- \core\mustache_template_source_loader_test => \core\output\mustache_template_source_loader_test
- \core\output_mustache_helper_collection_test => \core\output\mustache_helper_collection_test
- The following tests have been moved to their correct tests directories:
- lib/tests/time_splittings_test.php => analytics/tests/time_splittings_test.php
- All the classes and tests under lib/filebrowser and lib/filestorage
belong to core, not to core_files. Some day we should move
them to their correct subsystem.
- All the classes and tests under lib/grade belong to core, not
to core_grades. Some day we should move them to their correct
subsystem.
- The core_grades_external class and its \core\grades_external_test
unit test should belong to the grades subsystem or, alternatively,
to \core\external, they both should be moved together.
- The core_grading_external class and its \core\grading_external_test
unit test should belong to the grading subsystem or, alternatively,
to \core\external, they both should be moved together.
- The \core\message\message and \core\message\inbound (may be others)
classes, and their associated tests should go to the core_message
subsystem.
- The core_user class, and its associated tests should go to the
core_user subsystem.
- The \core\update namespace is plain wrong (update is not valid API)
and needs action 1) create it or 2) move elsewhere.
2022-07-01 16:43:34 +02:00
|
|
|
class adminlib_test extends \advanced_testcase {
|
2020-03-27 23:07:28 +11:00
|
|
|
|
|
|
|
/**
|
|
|
|
* Data provider of serialized string.
|
|
|
|
*
|
|
|
|
* @return array
|
|
|
|
*/
|
|
|
|
public function db_should_replace_dataprovider() {
|
|
|
|
return [
|
|
|
|
// Skipped tables.
|
|
|
|
['block_instances', '', false],
|
|
|
|
['config', '', false],
|
|
|
|
['config_plugins', '', false],
|
|
|
|
['config_log', '', false],
|
|
|
|
['events_queue', '', false],
|
|
|
|
['filter_config', '', false],
|
|
|
|
['log', '', false],
|
|
|
|
['repository_instance_config', '', false],
|
|
|
|
['sessions', '', false],
|
|
|
|
['upgrade_log', '', false],
|
|
|
|
|
|
|
|
// Unknown skipped tables.
|
|
|
|
['foobar_log', '', false],
|
|
|
|
['foobar_logs', '', false],
|
|
|
|
|
|
|
|
// Unknown ok tables.
|
|
|
|
['foobar_logical', '', true],
|
|
|
|
|
|
|
|
// Normal tables.
|
|
|
|
['assign', '', true],
|
|
|
|
|
|
|
|
// Normal tables with excluded columns.
|
|
|
|
['message_conversations', 'convhash', false],
|
|
|
|
['user_password_history', 'hash', false],
|
|
|
|
['foo', 'barhash', false],
|
|
|
|
];
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* Test which tables and column should be replaced.
|
|
|
|
*
|
|
|
|
* @dataProvider db_should_replace_dataprovider
|
2021-09-29 09:05:58 +08:00
|
|
|
* @covers ::db_should_replace
|
2020-03-27 23:07:28 +11:00
|
|
|
* @param string $table name
|
|
|
|
* @param string $column name
|
|
|
|
* @param bool $expected whether it should be replaced
|
|
|
|
*/
|
|
|
|
public function test_db_should_replace(string $table, string $column, bool $expected) {
|
|
|
|
$actual = db_should_replace($table, $column);
|
|
|
|
$this->assertSame($actual, $expected);
|
|
|
|
}
|
|
|
|
|
2020-10-02 13:10:51 +10:00
|
|
|
/**
|
|
|
|
* Data provider for additional skip tables.
|
|
|
|
*
|
2021-09-29 09:05:58 +08:00
|
|
|
* @covers ::db_should_replace
|
2020-10-02 13:10:51 +10:00
|
|
|
* @return array
|
|
|
|
*/
|
|
|
|
public function db_should_replace_additional_skip_tables_dataprovider() {
|
|
|
|
return [
|
|
|
|
// Skipped tables.
|
|
|
|
['block_instances', '', false],
|
|
|
|
['config', '', false],
|
|
|
|
['config_plugins', '', false],
|
|
|
|
['config_log', '', false],
|
|
|
|
['events_queue', '', false],
|
|
|
|
['filter_config', '', false],
|
|
|
|
['log', '', false],
|
|
|
|
['repository_instance_config', '', false],
|
|
|
|
['sessions', '', false],
|
|
|
|
['upgrade_log', '', false],
|
|
|
|
|
|
|
|
// Additional skipped tables.
|
|
|
|
['context', '', false],
|
|
|
|
['quiz_attempts', '', false],
|
|
|
|
['role_assignments', '', false],
|
|
|
|
|
|
|
|
// Normal tables.
|
|
|
|
['assign', '', true],
|
|
|
|
['book', '', true],
|
|
|
|
];
|
|
|
|
}
|
2020-03-27 23:07:28 +11:00
|
|
|
|
2020-10-02 13:10:51 +10:00
|
|
|
/**
|
|
|
|
* Test additional skip tables.
|
|
|
|
*
|
|
|
|
* @dataProvider db_should_replace_additional_skip_tables_dataprovider
|
2021-09-29 09:05:58 +08:00
|
|
|
* @covers ::db_should_replace
|
2020-10-02 13:10:51 +10:00
|
|
|
* @param string $table name
|
|
|
|
* @param string $column name
|
|
|
|
* @param bool $expected whether it should be replaced
|
|
|
|
*/
|
|
|
|
public function test_db_should_replace_additional_skip_tables(string $table, string $column, bool $expected) {
|
|
|
|
$this->resetAfterTest();
|
|
|
|
$additionalskiptables = 'context, quiz_attempts, role_assignments ';
|
|
|
|
$actual = db_should_replace($table, $column, $additionalskiptables);
|
|
|
|
$this->assertSame($actual, $expected);
|
|
|
|
}
|
2023-07-13 08:38:38 +02:00
|
|
|
|
|
|
|
/**
|
|
|
|
* Test method used by upgradesettings.php to make sure
|
|
|
|
* there are no missing settings in PHPUnit and Behat tests.
|
|
|
|
*
|
|
|
|
* @covers ::admin_output_new_settings_by_page
|
|
|
|
*/
|
|
|
|
public function test_admin_output_new_settings_by_page() {
|
|
|
|
$this->resetAfterTest();
|
|
|
|
$this->setAdminUser();
|
|
|
|
|
|
|
|
// Add settings not set during PHPUnit init.
|
|
|
|
set_config('supportemail', 'support@example.com');
|
|
|
|
$frontpage = new \admin_setting_special_frontpagedesc();
|
|
|
|
$frontpage->write_setting('test test');
|
|
|
|
|
|
|
|
// NOTE: if this test fails then it is most likely extra setting in
|
|
|
|
// some additional plugin without default - developer needs to add
|
|
|
|
// a workaround into their db/install.php for PHPUnit and Behat.
|
|
|
|
|
|
|
|
$root = admin_get_root(true, true);
|
|
|
|
$new = admin_output_new_settings_by_page($root);
|
|
|
|
$this->assertSame([], $new);
|
|
|
|
|
|
|
|
unset_config('numbering', 'book');
|
|
|
|
unset_config('supportemail');
|
|
|
|
$root = admin_get_root(true, true);
|
|
|
|
$new = admin_output_new_settings_by_page($root);
|
|
|
|
$this->assertCount(2, $new);
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* Test repeated recursive application of default settings.
|
|
|
|
*
|
|
|
|
* @covers ::admin_apply_default_settings
|
|
|
|
*/
|
|
|
|
public function test_admin_apply_default_settings() {
|
|
|
|
global $DB;
|
|
|
|
|
|
|
|
$this->resetAfterTest();
|
|
|
|
$this->setAdminUser();
|
|
|
|
|
|
|
|
// There should not be any pending new defaults.
|
|
|
|
$saved = admin_apply_default_settings(null, false);
|
|
|
|
$this->assertSame([], $saved);
|
|
|
|
|
|
|
|
// Emulation of upgrades from CLI.
|
|
|
|
unset_config('logocompact', 'core_admin');
|
|
|
|
unset_config('grade_aggregationposition');
|
|
|
|
unset_config('numbering', 'book');
|
|
|
|
unset_config('enabled', 'core_competency');
|
|
|
|
unset_config('pushcourseratingstouserplans', 'core_competency');
|
|
|
|
$saved = admin_apply_default_settings(null, false);
|
|
|
|
$expected = [
|
|
|
|
'core_competency/enabled' => '1',
|
|
|
|
'grade_aggregationposition' => '1',
|
|
|
|
'book/numbering' => '1',
|
|
|
|
'core_admin/logocompact' => '',
|
|
|
|
'core_competency/pushcourseratingstouserplans' => '1',
|
|
|
|
];
|
|
|
|
$this->assertEquals($expected, $saved);
|
|
|
|
|
|
|
|
// Repeated application of defaults - not done usually.
|
|
|
|
$saved = admin_apply_default_settings(null, true);
|
|
|
|
$this->assertGreaterThan(500, count($saved));
|
|
|
|
$saved = admin_apply_default_settings();
|
|
|
|
$this->assertGreaterThan(500, count($saved));
|
|
|
|
|
|
|
|
// Emulate initial application of defaults.
|
|
|
|
$DB->delete_records('config', []);
|
|
|
|
$DB->delete_records('config_plugins', []);
|
|
|
|
purge_all_caches();
|
|
|
|
$saved = admin_apply_default_settings(null, true);
|
|
|
|
$this->assertGreaterThan(500, count($saved));
|
|
|
|
|
|
|
|
// Make sure there were enough repetitions.
|
|
|
|
$saved = admin_apply_default_settings(null, false);
|
|
|
|
$this->assertSame([], $saved);
|
|
|
|
}
|
2020-10-02 13:10:51 +10:00
|
|
|
}
|