mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-04-14 04:52:36 +02:00
Code Issues Projects Releases Wiki Activity

MDL-50085 output: Remove component and subtype from renderer

Browse Source 
They were only added to support templates, and due to refactoring
are not required any more. So we should remove this API change.
This commit is contained in:
Damyon Wiese 2015-05-04 14:20:30 +08:00 committed by Eloy Lafuente (stronk7)
parent 410034eef0
commit 003577cd85
2 changed files with 5 additions and 52 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
lib/outputfactories.php
View File

@ -337,10 +337,7 @@ class standard_renderer_factory extends renderer_factory_base {
throw new coding_exception('Request for an unknown renderer class. Searched for: ' . var_export($classnames, true));
}
$renderer = new $classname($page, $target);
$renderer->set_component($component);
$renderer->set_subtype($subtype);
return $renderer;
return new $classname($page, $target);
}
}
@ -404,10 +401,7 @@ class theme_overridden_renderer_factory extends renderer_factory_base {
$newclassname = $prefix . '_' . $classnamedetails['classname'] . $suffix;
}
if (class_exists($newclassname)) {
$renderer = new $newclassname($page, $target);
$renderer->set_component($component);
$renderer->set_subtype($subtype);
return $renderer;
return new $newclassname($page, $target);
}
}
}
@ -418,10 +412,7 @@ class theme_overridden_renderer_factory extends renderer_factory_base {
if (class_exists($newclassname)) {
// Use the specialised renderer for given target, default renderer might also decide
// to implement support for more targets.
$renderer = new $newclassname($page, $target);
$renderer->set_component($component);
$renderer->set_subtype($subtype);
return $renderer;
return new $newclassname($page, $target);
}
}
}
@ -436,10 +427,7 @@ class theme_overridden_renderer_factory extends renderer_factory_base {
$newclassname = $prefix . '_' . $classnamedetails['classname'];
}
if (class_exists($newclassname)) {
$renderer = new $newclassname($page, $target);
$renderer->set_component($component);
$renderer->set_subtype($subtype);
return $renderer;
return new $newclassname($page, $target);
}
}
}
@ -450,10 +438,7 @@ class theme_overridden_renderer_factory extends renderer_factory_base {
if ($classnamedetails['validwithoutprefix']) {
$newclassname = $classnamedetails['classname'];
if (class_exists($newclassname)) {
$renderer = new $newclassname($page, $target);
$renderer->set_component($component);
$renderer->set_subtype($subtype);
return $renderer;
return new $newclassname($page, $target);
}
}
}

32
lib/outputrenderers.php
View File

@ -71,38 +71,6 @@ class renderer_base {
*/
private $mustache;
/**
* @var string $component The component used when requesting this renderer.
*/
private $component;
/**
* @var string $subtype The subtype used when requesting this renderer.
*/
private $subtype;
/**
* This is not done in the constructor because that would be a
* compatibility breaking change, and we can just pass this always in the
* renderer factory, immediately after creating the renderer.
* @since 2.9
* @param string $subtype
*/
public function set_subtype($subtype) {
$this->subtype = $subtype;
}
/**
* This is not done in the constructor because that would be a
* compatibility breaking change, and we can just pass this always in the
* renderer factory, immediately after creating the renderer.
* @since 2.9
* @param string $component
*/
public function set_component($component) {
$this->component = $component;
}
/**
* Return an instance of the mustache class.
*