mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-07-12 18:06:41 +02:00
Code Issues Projects Releases Wiki Activity

MDL-77350 calendar: Added class properties that are not declared

Browse Source 
In PHP 8.2 and later, setting a value to an undeclared class property is
deprecated and emits a deprecation notice.
So we need to add missing class properties that still need to be declared.
This commit is contained in:
Meirza
2023-01-21 00:11:33 +07:00
parent 0d3a840154
commit 00bea84ed6
2 changed files with 16 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
calendar/lib.php
View File

@ -1066,6 +1066,18 @@ class calendar_information {
/** @var string The calendar's view mode. */ /** @var string The calendar's view mode. */
protected $viewmode; protected $viewmode;
/** @var \stdClass course data. */
public $course;
/** @var int day. */
protected $day;
/** @var int month. */
protected $month;
/** @var int year. */
protected $year;
/** /**
* Creates a new instance * Creates a new instance
* *

8
calendar/tests/event_factory_test.php
View File

@ -75,7 +75,10 @@ class event_factory_test extends \advanced_testcase {
} }
if ($expectedattributevalue) { if ($expectedattributevalue) {
$this->assertEquals($instance->testattribute, $expectedattributevalue); $this->assertEquals(
$instance->get_description()->get_value(),
$expectedattributevalue
);
} }
} }
@ -368,7 +371,6 @@ class event_factory_test extends \advanced_testcase {
'location' => 'Test location', 'location' => 'Test location',
], ],
'actioncallbackapplier' => function(event_interface $event) { 'actioncallbackapplier' => function(event_interface $event) {
$event->testattribute = 'Hello';
return $event; return $event;
}, },
'visibilitycallbackapplier' => function(event_interface $event) { 'visibilitycallbackapplier' => function(event_interface $event) {
@ -403,7 +405,6 @@ class event_factory_test extends \advanced_testcase {
'location' => 'Test location', 'location' => 'Test location',
], ],
'actioncallbackapplier' => function(event_interface $event) { 'actioncallbackapplier' => function(event_interface $event) {
$event->testattribute = 'Hello';
return $event; return $event;
}, },
'visibilitycallbackapplier' => function(event_interface $event) { 'visibilitycallbackapplier' => function(event_interface $event) {
@ -438,7 +439,6 @@ class event_factory_test extends \advanced_testcase {
'location' => 'Test location', 'location' => 'Test location',
], ],
'actioncallbackapplier' => function(event_interface $event) { 'actioncallbackapplier' => function(event_interface $event) {
$event->testattribute = 'Hello';
return $event; return $event;
}, },
'visibilitycallbackapplier' => function(event_interface $event) { 'visibilitycallbackapplier' => function(event_interface $event) {