From 01ae473823f5a1a0909c1829fb87542ce761b962 Mon Sep 17 00:00:00 2001 From: Paul Holden Date: Wed, 15 Feb 2023 18:30:09 +0000 Subject: [PATCH] MDL-77264 grade: define fallback name of abstract export event. --- lang/en/grades.php | 1 + lib/classes/event/grade_exported.php | 22 +++++++++------------- 2 files changed, 10 insertions(+), 13 deletions(-) diff --git a/lang/en/grades.php b/lang/en/grades.php index ee679426b6a..76a113d2d39 100644 --- a/lang/en/grades.php +++ b/lang/en/grades.php @@ -197,6 +197,7 @@ $string['errorupdatinggradecategoryaggregateoutcomes'] = 'Error updating the "In $string['errorupdatinggradecategoryaggregation'] = 'Error updating the aggregation type of grade category ID {$a->id}'; $string['errorupdatinggradeitemaggregationcoef'] = 'Error updating the aggregation coefficient (weight or extra credit) of grade item ID {$a->id}'; $string['eventgradedeleted'] = 'Grade deleted'; +$string['eventgradeexported'] = 'Grade exported'; $string['eventgradeitemcreated'] = 'Grade item created'; $string['eventgradeitemdeleted'] = 'Grade item deleted'; $string['eventgradeitemupdated'] = 'Grade item updated'; diff --git a/lib/classes/event/grade_exported.php b/lib/classes/event/grade_exported.php index 88e1e31fb29..fe4a66bdb09 100644 --- a/lib/classes/event/grade_exported.php +++ b/lib/classes/event/grade_exported.php @@ -14,20 +14,10 @@ // You should have received a copy of the GNU General Public License // along with Moodle. If not, see . -/** - * Grade report viewed event. - * - * @package core - * @copyright 2016 Zane Karl - * @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later - */ - namespace core\event; -defined('MOODLE_INTERNAL') || die(); - /** - * Grade report viewed event class. + * Abstract grade report exported event class. * * @package core * @since Moodle 3.2 @@ -55,7 +45,7 @@ abstract class grade_exported extends base { public static function get_export_type() { $classname = explode('\\', get_called_class()); $exporttype = explode('_', $classname[0]); - return $exporttype[1]; + return $exporttype[1] ?? ''; } /** @@ -64,7 +54,13 @@ abstract class grade_exported extends base { * @return string */ public static function get_name() { - return get_string('eventgradeexported', 'gradeexport_'. self::get_export_type()); + $component = 'gradeexport_' . self::get_export_type(); + if (get_string_manager()->string_exists('eventgradeexported', $component)) { + return get_string('eventgradeexported', $component); + } + + // Fallback to generic name. + return get_string('eventgradeexported', 'core_grades'); } /**