mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-01-18 22:08:20 +01:00
Code Issues Projects Releases Wiki Activity

MDL-51360 mod_quiz: Don't do full course recalculation.

Browse Source 
It seems it was never needed. We only need to know if just one
grade is overridden and its value.
This commit is contained in:
Ilya Tregubov 2024-05-06 12:14:32 +08:00
parent f88dbfcafc
commit 0219831af4
1 changed files with 24 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
mod/quiz/view.php
View File

@ -126,21 +126,33 @@ if (!$canpreview) {
$mygradeoverridden = false;
$gradebookfeedback = '';
$item = null;
$gradinginfo = grade_get_grades($course->id, 'mod', 'quiz', $quiz->id, $USER->id);
if (!empty($gradinginfo->items)) {
$item = $gradinginfo->items[0];
if (isset($item->grades[$USER->id])) {
$grade = $item->grades[$USER->id];
$gradeitem = grade_item::fetch([
'itemtype' => 'mod',
'itemmodule' => 'quiz',
'iteminstance' => $quiz->id,
'itemnumber' => 0,
'courseid' => $course->id,
]);
if ($gradeitem) {
if ($gradeitem->refresh_grades($USER->id)) {
$grade = $gradeitem->get_grade($USER->id, false);
if ($grade->overridden) {
$mygrade = $grade->grade + 0; // Convert to number.
if ($gradeitem->needsupdate) {
// It is Error, but let's be consistent with the old code.
$mygrade = 0;
} else {
$mygrade = $grade->finalgrade;
}
$mygradeoverridden = true;
}
if (!empty($grade->str_feedback)) {
$gradebookfeedback = $grade->str_feedback;
if (!empty($grade->feedback)) {
$gradebookfeedback = $grade->feedback;
}
} else {
// It is Error, but let's be consistent with the old code.
$mygrade = 0;
}
}
@ -197,9 +209,9 @@ if ($quiz->attempts != 1) {
}
// Inform user of the grade to pass if non-zero.
if ($item && grade_floats_different($item->gradepass, 0)) {
if ($gradeitem && grade_floats_different($gradeitem->gradepass, 0)) {
$a = new stdClass();
$a->grade = quiz_format_grade($quiz, $item->gradepass);
$a->grade = quiz_format_grade($quiz, $gradeitem->gradepass);
$a->maxgrade = quiz_format_grade($quiz, $quiz->grade);
$viewobj->infomessages[] = get_string('gradetopassoutof', 'quiz', $a);
}