mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-01-17 21:49:15 +01:00
Code Issues Projects Releases Wiki Activity

MDL-82596 behat: tidy up existing usage of private files generator.

Browse Source 
Filename is no longer required (since 83db25c330), given it never
did anything so can be removed. Requiring the "Private files" block
also isn't necessary since original switch to generator methods.
This commit is contained in:
Paul Holden 2024-07-25 19:58:37 +01:00
parent d8a1a67fd7
commit 0223b0fefb
No known key found for this signature in database
GPG Key ID: A81A96D6045F6164
7 changed files with 12 additions and 33 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
customfield/field/textarea/tests/behat/default_value.feature
View File

@ -21,12 +21,9 @@ Feature: Default value for the textarea custom field can contain images
And the following "custom field categories" exist: And the following "custom field categories" exist:
| name | component | area | itemid | | name | component | area | itemid |
| Category for test | core_course | course | 0 | | Category for test | core_course | course | 0 |
And the following "blocks" exist:
| blockname | contextlevel | reference | pagetypepattern | defaultregion |
| private_files | System | 1 | my-index | side-post |
And the following "user private files" exist: And the following "user private files" exist:
| user | filepath | filename | | user | filepath |
| admin | lib/tests/fixtures/gd-logo.png | gd-logo.png | | admin | lib/tests/fixtures/gd-logo.png |
And I log in as "admin" And I log in as "admin"
And I navigate to "Courses > Default settings > Course custom fields" in site administration And I navigate to "Courses > Default settings > Course custom fields" in site administration
And I click on "Add a new custom field" "link" And I click on "Add a new custom field" "link"

7
customfield/tests/behat/edit_fields_settings.feature
View File

@ -25,12 +25,9 @@ Feature: Teachers can edit course custom fields
And the following "course enrolments" exist: And the following "course enrolments" exist:
| user | course | role | | user | course | role |
| teacher1 | C1 | editingteacher | | teacher1 | C1 | editingteacher |
And the following "blocks" exist:
| blockname | contextlevel | reference | pagetypepattern | defaultregion |
| private_files | System | 1 | my-index | side-post |
And the following "user private files" exist: And the following "user private files" exist:
| user | filepath | filename | | user | filepath |
| admin | lib/tests/fixtures/gd-logo.png | gd-logo.png | | admin | lib/tests/fixtures/gd-logo.png |
Scenario: Display custom fields on course edit form Scenario: Display custom fields on course edit form
When I log in as "teacher1" When I log in as "teacher1"

3
filter/displayh5p/tests/behat/h5p_filter.feature
View File

@ -14,9 +14,6 @@ Feature: Render H5P content using filters
| user | course | role | | user | course | role |
| teacher1 | C1 | editingteacher | | teacher1 | C1 | editingteacher |
| student1 | C1 | student | | student1 | C1 | student |
And the following "blocks" exist:
| blockname | contextlevel | reference | pagetypepattern | defaultregion |
| private_files | System | 1 | my-index | side-post |
And the "displayh5p" filter is "on" And the "displayh5p" filter is "on"
And the following config values are set as admin: And the following config values are set as admin:
| allowedsources | https://moodle.h5p.com/content/[id]/embed | filter_displayh5p | | allowedsources | https://moodle.h5p.com/content/[id]/embed | filter_displayh5p |

7
mod/lesson/tests/behat/duplicate_lesson_page.feature
View File

@ -20,12 +20,9 @@ Feature: In a lesson activity, a teacher can duplicate a lesson page
| course | C1 | | course | C1 |
| activity | lesson | | activity | lesson |
| name | Test lesson name | | name | Test lesson name |
And the following "blocks" exist:
| blockname | contextlevel | reference | pagetypepattern | defaultregion |
| private_files | System | 1 | my-index | side-post |
And the following "user private files" exist: And the following "user private files" exist:
| user | filepath | filename | | user | filepath |
| teacher1 | mod/lesson/tests/fixtures/moodle_logo.jpg | moodle_logo.jpg | | teacher1 | mod/lesson/tests/fixtures/moodle_logo.jpg |
And I log in as "teacher1" And I log in as "teacher1"
Scenario: Duplicate content page with an image. Scenario: Duplicate content page with an image.

7
mod/lesson/tests/behat/questions_images.feature
View File

@ -20,12 +20,9 @@ Feature: In a lesson activity, teacher can add embedded images in questions answ
| course | C1 | | course | C1 |
| activity | lesson | | activity | lesson |
| name | Test lesson name | | name | Test lesson name |
And the following "blocks" exist:
| blockname | contextlevel | reference | pagetypepattern | defaultregion |
| private_files | System | 1 | my-index | side-post |
And the following "user private files" exist: And the following "user private files" exist:
| user | filepath | filename | | user | filepath |
| teacher1 | mod/lesson/tests/fixtures/moodle_logo.jpg | moodle_logo.jpg | | teacher1 | mod/lesson/tests/fixtures/moodle_logo.jpg |
And I log in as "teacher1" And I log in as "teacher1"
When I am on the "Test lesson name" "lesson activity" page When I am on the "Test lesson name" "lesson activity" page
And I follow "Add a question page" And I follow "Add a question page"

7
mod/quiz/tests/behat/manually_mark_question.feature
View File

@ -28,12 +28,9 @@ Feature: Teachers can override the grade for any question
And quiz "Quiz 1" contains the following questions: And quiz "Quiz 1" contains the following questions:
| question | page | | question | page |
| TF1 | 1 | | TF1 | 1 |
And the following "blocks" exist:
| blockname | contextlevel | reference | pagetypepattern | defaultregion |
| private_files | System | 1 | my-index | side-post |
And the following "user private files" exist: And the following "user private files" exist:
| user | filepath | filename | | user | filepath |
| teacher1 | mod/quiz/tests/fixtures/moodle_logo.jpg | moodle_logo.jpg | | teacher1 | mod/quiz/tests/fixtures/moodle_logo.jpg |
And I am on the "Quiz 1" "mod_quiz > View" page logged in as "student1" And I am on the "Quiz 1" "mod_quiz > View" page logged in as "student1"
And I press "Attempt quiz" And I press "Attempt quiz"
And I follow "Finish attempt ..." And I follow "Finish attempt ..."

7
mod/workshop/tests/behat/embedded_images.feature
View File

@ -10,17 +10,14 @@ Feature: Teachers can embed images into instructions and conclusion fields
| username | firstname | lastname | email | | username | firstname | lastname | email |
| teacher1 | Teacher | One | teacher1@example.com | | teacher1 | Teacher | One | teacher1@example.com |
And the following "user private files" exist: And the following "user private files" exist:
| user | filepath | filename | | user | filepath |
| teacher1 | mod/workshop/tests/fixtures/moodlelogo.png | moodlelogo.png | | teacher1 | mod/workshop/tests/fixtures/moodlelogo.png |
And the following "courses" exist: And the following "courses" exist:
| fullname | shortname | | fullname | shortname |
| Course 1 | C1 | | Course 1 | C1 |
And the following "course enrolments" exist: And the following "course enrolments" exist:
| user | course | role | | user | course | role |
| teacher1 | C1 | editingteacher | | teacher1 | C1 | editingteacher |
And the following "blocks" exist:
| blockname | contextlevel | reference | pagetypepattern | defaultregion |
| private_files | System | 1 | my-index | side-post |
And the following "activities" exist: And the following "activities" exist:
| activity | course | name | | activity | course | name |
| workshop | C1 | Workshop with embedded images | | workshop | C1 | Workshop with embedded images |