mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-04-21 00:12:56 +02:00
Code Issues Projects Releases Wiki Activity

Merge branch 'MDL-51623_parent_event' of git://github.com/moodlerooms/moodle

Browse Source
This commit is contained in:
David Monllao 2015-10-08 15:53:00 +08:00
commit 02c85f9934
2 changed files with 49 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lib/classes/event/manager.php
View File

@ -176,11 +176,6 @@ class manager {
* @return array
*/
protected static function get_observing_classes(\core\event\base $event) {
$observers = array('\core\event\base', '\\'.get_class($event));
return $observers;
// Note if we ever decide to observe events by parent class name use the following code instead.
/*
$classname = get_class($event);
$observers = array('\\'.$classname);
while ($classname = get_parent_class($classname)) {
@ -189,7 +184,6 @@ class manager {
$observers = array_reverse($observers, false);
return $observers;
*/
}
/**

49
lib/tests/event_test.php
View File

@ -924,4 +924,53 @@ and nothing else.";
);
$this->assertEquals($staticinfo, $expected);
}
/**
* This tests the internal method of \core\event\manager::get_observing_classes.
*
* What we are testing is if we can subscribe to a parent event class, instead of only
* the base event class or the final, implemented event class. This enables us to subscribe
* to things like all course module view events, all comment created events, etc.
*/
public function test_observe_parent_event() {
$this->resetAfterTest();
// Ensure this has been reset prior to using it.
\core_tests\event\unittest_observer::reset();
$course = $this->getDataGenerator()->create_course();
$feed = $this->getDataGenerator()->create_module('feedback', ['course' => $course->id]);
$context = context_module::instance($feed->cmid);
$data = [
'context' => $context,
'courseid' => $course->id,
'objectid' => $feed->id
];
// This assertion ensures that basic observe use case did not break.
\core\event\manager::phpunit_replace_observers([[
'eventname' => '\core_tests\event\course_module_viewed',
'callback' => ['\core_tests\event\unittest_observer', 'observe_all_alt'],
]]);
$pageevent = \core_tests\event\course_module_viewed::create($data);
$pageevent->trigger();
$this->assertSame(['observe_all_alt'], \core_tests\event\unittest_observer::$info, 'Can still subscribe to child event');
\core_tests\event\unittest_observer::reset();
// This assertion tests that we can observe an abstract (parent) class instead of the implemented class.
\core\event\manager::phpunit_replace_observers([[
'eventname' => '\core\event\course_module_viewed',
'callback' => ['\core_tests\event\unittest_observer', 'observe_all_alt'],
]]);
$pageevent = \core_tests\event\course_module_viewed::create($data);
$pageevent->trigger();
$this->assertSame(['observe_all_alt'], \core_tests\event\unittest_observer::$info, 'Can subscribe to parent event');
\core_tests\event\unittest_observer::reset();
}
}