mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-01-31 12:45:04 +01:00
Code Issues Projects Releases Wiki Activity

Changed optional_variables()s and required_variable()s to more secure alternatives.

Browse Source
This commit is contained in:
thepurpleblob 2005-06-10 19:47:11 +00:00
parent 5a69215fd0
commit 03c2200ef4
2 changed files with 10 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
course/student.php
View File

@ -5,10 +5,10 @@
define("MAX_USERS_PER_PAGE", 5000);
require_variable($id); // course id
optional_variable($add, "");
optional_variable($remove, "");
optional_variable($search, ""); // search string
$id = required_param('id',PARAM_INT); // course id
$add = optional_param('add', "", PARAM_ALPHA);
$remove = optional_param('remove', "", PARAM_ALPHA);
$search = optional_param('search', "", PARAM_CLEAN); // search string
if (! $site = get_site()) {
redirect("$CFG->wwwroot/$CFG->admin/index.php");

12
course/teacher.php
View File

@ -5,10 +5,10 @@
define("MAX_USERS_PER_PAGE", 50);
require_variable($id); // course id
optional_variable($add, "");
optional_variable($remove, "");
optional_variable($search, ""); // search string
$id = required_param('id',PARAM_INT); // course id
$add = optional_param('add', '', PARAM_ALPHA);
$remove = optional_param('remove', '', PARAM_ALPHA);
$search = optional_param('search', '', PARAM_CLEAN); // search string
require_login();
@ -96,7 +96,7 @@
/// Add a teacher if one is specified
if (!empty($_GET['add']) and confirm_sesskey()) {
if (!empty($add) and confirm_sesskey()) {
if (! add_teacher($add, $course->id)) {
error("Could not add that teacher to this course!");
}
@ -104,7 +104,7 @@
/// Remove a teacher if one is specified.
if (!empty($_GET['remove']) and confirm_sesskey()) {
if (!empty($remove) and confirm_sesskey()) {
if (! remove_teacher($remove, $course->id)) {
error("Could not remove that teacher from this course!");
}