mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-04-21 00:12:56 +02:00
Code Issues Projects Releases Wiki Activity

MDL-42560 Events: Removed use of role->name

Browse Source 
role->name is usually empty or localized, so should not be used in events
This commit is contained in:
Rajesh Taneja 2013-10-28 10:42:27 +08:00
parent 68291f2d57
commit 045d913d11
4 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
admin/roles/define.php
View File

@ -201,8 +201,7 @@ if (optional_param('savechanges', false, PARAM_BOOL) && confirm_sesskey() && $de
$event = \core\event\role_capabilities_updated::create(
array(
'context' => $systemcontext,
'objectid' => $roleid,
'other' => array('name' => $definitiontable->get_role_name())
'objectid' => $roleid
)
);
$event->set_legacy_logdata(array(SITEID, 'role', $action, 'admin/roles/define.php?action=view&roleid=' . $tableroleid,

3
admin/roles/override.php
View File

@ -130,8 +130,7 @@ if (optional_param('savechanges', false, PARAM_BOOL) && confirm_sesskey()) {
array(
'context' => $context,
'objectid' => $roleid,
'courseid' => $courseid,
'other' => array('name' => $rolename)
'courseid' => $courseid
)
);

1
lib/accesslib.php
View File

@ -1528,7 +1528,6 @@ function delete_role($roleid) {
'objectid' => $roleid,
'other' =>
array(
'name' => $role->name,
'shortname' => $role->shortname,
'description' => $role->description,
'archetype' => $role->archetype

1
lib/tests/accesslib_test.php
View File

@ -699,7 +699,6 @@ class core_accesslib_testcase extends advanced_testcase {
$this->assertSame('role', $event->objecttable);
$this->assertSame($role->id, $event->objectid);
$this->assertEquals(context_system::instance(), $event->get_context());
$this->assertSame($role->name, $event->other['name']);
$this->assertSame($role->shortname, $event->other['shortname']);
$this->assertSame($role->description, $event->other['description']);
$this->assertSame($role->archetype, $event->other['archetype']);