mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-04-12 20:12:15 +02:00
Code Issues Projects Releases Wiki Activity

rating MDL-23389 altered the grade retrieval sql to avoid something postgres doesnt like

Browse Source
This commit is contained in:
Andrew Davis 2010-07-19 09:13:13 +00:00
parent db42bc5aaa
commit 06807529ba
1 changed files with 16 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
rating/lib.php
View File

@ -250,6 +250,7 @@ class rating_manager {
return $options->items;
}
$userid = null;
if (empty($options->userid)) {
$userid = $USER->id;
} else {
@ -436,7 +437,7 @@ class rating_manager {
/**
* Returns an array of grades calculated by aggregating item ratings.
* @param object $options {
* userid => int the id of the user whose items have been rated. NOT the user who submitted the ratings [required]
* userid => int the id of the user whose items have been rated. NOT the user who submitted the ratings. 0 to update all. [required]
* aggregationmethod => int the aggregation method to apply when calculating grades ie RATING_AGGREGATE_AVERAGE [required]
* scaleid => int the scale from which the user can select a rating. Used for bounds checking. [required]
* itemtable => int the table containing the items [required]
@ -465,7 +466,7 @@ class rating_manager {
}
else if ( !empty($options->modulename) && !empty($options->moduleid) ) {
$modulename = $options->modulename;
$moduleid = $options->moduleid;
$moduleid = intval($options->moduleid);
//going direct to the db for the context id seems wrong
list($ctxselect, $ctxjoin) = context_instance_preload_sql('cm.id', CONTEXT_MODULE, 'ctx');
@ -485,23 +486,22 @@ class rating_manager {
$scaleid = $options->scaleid;
$aggregationstring = $this->get_aggregation_method($options->aggregationmethod);
//if userid is 0 we want all user grades within this context
//if userid is not 0 we only want the grade for a single user
$singleuserwhere = '';
if ($options->userid!=0) {
$params['userid1'] = $params['userid2'] = $params['userid3'] = $options->userid;
$sql = "SELECT :userid1 AS id, :userid2 AS userid, $aggregationstring(r.rating) AS rawgrade
FROM {rating} r
JOIN {{$itemtable}} i ON r.itemid=i.id
WHERE r.contextid=:contextid
AND i.{$itemtableusercolumn} = :userid3";
} else {
$sql = "SELECT u.id as id, u.id AS userid, $aggregationstring(r.rating) AS rawgrade
FROM {user} u
LEFT JOIN {{$itemtable}} i ON u.id=i.{$itemtableusercolumn}
LEFT JOIN {rating} r ON r.itemid=i.id
WHERE (r.contextid is null or r.contextid=:contextid)
GROUP BY u.id";
$params['userid1'] = intval($options->userid);
$singleuserwhere = "AND i.{$itemtableusercolumn} = :userid1";
}
//note: r.contextid will be null for users who haven't been rated yet
$sql = "SELECT u.id as id, u.id AS userid, $aggregationstring(r.rating) AS rawgrade
FROM {user} u
LEFT JOIN {{$itemtable}} i ON u.id=i.{$itemtableusercolumn}
LEFT JOIN {rating} r ON r.itemid=i.id
WHERE (r.contextid is null or r.contextid=:contextid)
$singleuserwhere
GROUP BY u.id";
$results = $DB->get_records_sql($sql, $params);
if ($results) {