mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-04-13 04:22:07 +02:00
Code Issues Projects Releases Wiki Activity

MDL-30955 rating: corrected /rating/index.php as it was determining the maximum rating incorrectly for custom scales

Browse Source
This commit is contained in:
Andrew Davis 2012-04-10 12:01:52 +07:00
parent 9ad535c550
commit 08f06b1c24
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
rating/index.php
View File

@ -102,8 +102,10 @@ if (!$ratings) {
$table->colclasses = array('', 'firstname', 'rating', 'time');
$table->data = array();
//if the scale was changed after ratings were submitted some ratings may have a value above the current maximum
$maxrating = count($scalemenu) - 1;
// If the scale was changed after ratings were submitted some ratings may have a value above the current maximum
// We can't just do count($scalemenu) - 1 as custom scales start at index 1, not 0
$maxrating = max(array_keys($scalemenu));
foreach ($ratings as $rating) {
//Undo the aliasing of the user id column from user_picture::fields()
//we could clone the rating object or preserve the rating id if we needed it again