MDL-82328 auth_oauth2: don't load custom profile field data too early.

By prematurely loading custom profile data in the constructor, under
specific circumstances it would happen before the page was fully
initialised which meant that any attempt at applying filters when
formatting profile field data would result in thrown exception.
This commit is contained in:
Paul Holden 2024-06-27 22:42:12 +01:00
parent 9557a52569
commit 0aeff04c0a
No known key found for this signature in database
GPG Key ID: A81A96D6045F6164

View File

@ -63,7 +63,6 @@ class auth extends \auth_plugin_base {
public function __construct() {
$this->authtype = 'oauth2';
$this->config = get_config('auth_oauth2');
$this->customfields = $this->get_custom_user_profile_fields();
}
/**
@ -310,7 +309,7 @@ class auth extends \auth_plugin_base {
return $userdata;
}
$allfields = array_merge($this->userfields, $this->customfields);
$allfields = array_merge($this->userfields, $this->get_custom_user_profile_fields());
// Go through each field from the external data.
foreach ($externaldata as $fieldname => $value) {