mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-01-29 11:46:19 +01:00
Code Issues Projects Releases Wiki Activity

MDL-64588 core_comment: fix unnecessary type check in add_comments

Browse Source 
We should rely on the return type, else an exception with be thrown.
This commit is contained in:
Jake Dallimore 2019-09-17 11:43:22 +08:00
parent 93ea6612bd
commit 0c3eaf9ee6
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
comment/classes/external.php
View File

@ -254,10 +254,8 @@ class core_comment_external extends external_api {
foreach ($params['comments'] as $comment) {
$manager = $comment['preparedcomment'];
$newcomment = $manager->add($comment['content']);
if (!empty($newcomment) && is_object($newcomment)) {
$results[] = $newcomment;
}
$newcomment->delete = true; // USER created the comment, so they can delete it.
$results[] = $newcomment;
}
return $results;