From 0cced3ced3f69a90bdf34a6d55e1038000b1f123 Mon Sep 17 00:00:00 2001 From: Jake Dallimore Date: Fri, 27 May 2016 11:22:55 +0800 Subject: [PATCH] MDL-54745 mod_assign: Remove leftover changegradewarning string and js --- mod/assign/lang/en/assign.php | 4 +++- mod/assign/lang/en/deprecated.txt | 1 + mod/assign/module.js | 12 ------------ 3 files changed, 4 insertions(+), 13 deletions(-) create mode 100644 mod/assign/lang/en/deprecated.txt diff --git a/mod/assign/lang/en/assign.php b/mod/assign/lang/en/assign.php index 2f51ed31d60..097a09f4e74 100644 --- a/mod/assign/lang/en/assign.php +++ b/mod/assign/lang/en/assign.php @@ -104,7 +104,6 @@ $string['blindmarkingenabledwarning'] = 'Blind marking is enabled for this activ $string['blindmarking_help'] = 'Blind marking hides the identity of students from markers. Blind marking settings will be locked once a submission or grade has been made in relation to this assignment.'; $string['changeuser'] = 'Change user'; $string['changefilters'] = 'Change filters'; -$string['changegradewarning'] = 'This assignment has graded submissions and changing the grade will not automatically re-calculate existing submission grades. You must re-grade all existing submissions, if you wish to change the grade.'; $string['choosegradingaction'] = 'Grading action'; $string['choosemarker'] = 'Choose...'; $string['chooseoperation'] = 'Choose operation'; @@ -503,3 +502,6 @@ $string['viewsubmissiongradingtable'] = 'View submission grading table.'; $string['viewrevealidentitiesconfirm'] = 'View reveal student identities confirmation page.'; $string['workflowfilter'] = 'Workflow filter'; $string['xofy'] = '{$a->x} of {$a->y}'; + +// Deprecated since Moodle 3.2. +$string['changegradewarning'] = 'This assignment has graded submissions and changing the grade will not automatically re-calculate existing submission grades. You must re-grade all existing submissions, if you wish to change the grade.'; diff --git a/mod/assign/lang/en/deprecated.txt b/mod/assign/lang/en/deprecated.txt new file mode 100644 index 00000000000..76d8f54a371 --- /dev/null +++ b/mod/assign/lang/en/deprecated.txt @@ -0,0 +1 @@ +changegradewarning,mod_assign \ No newline at end of file diff --git a/mod/assign/module.js b/mod/assign/module.js index 1e0655e6a30..3504927052c 100644 --- a/mod/assign/module.js +++ b/mod/assign/module.js @@ -150,18 +150,6 @@ M.mod_assign.init_grading_options = function(Y) { }); }; -M.mod_assign.init_grade_change = function(Y) { - var gradenode = Y.one('#id_grade'); - if (gradenode) { - var originalvalue = gradenode.get('value'); - gradenode.on('change', function() { - if (gradenode.get('value') != originalvalue) { - alert(M.util.get_string('changegradewarning', 'mod_assign')); - } - }); - } -}; - M.mod_assign.init_plugin_summary = function(Y, subtype, type, submissionid) { suffix = subtype + '_' + type + '_' + submissionid; classname = 'contract_' + suffix;