MDL-40424 user: Incorrect use of named parameters

This commit is contained in:
Frederic Massart 2013-07-17 09:45:42 +08:00 committed by Marina Glancy
parent 576151c987
commit 0d352dbcdd

View File

@ -678,7 +678,7 @@ class core_user_external extends external_api {
$params = self::validate_parameters(self::get_users_by_id_parameters(),
array('userids'=>$userids));
list($sqluserids, $params) = $DB->get_in_or_equal($userids);
list($sqluserids, $params) = $DB->get_in_or_equal($userids, SQL_PARAMS_NAMED);
$uselect = ', ' . context_helper::get_preload_record_columns_sql('ctx');
$ujoin = "LEFT JOIN {context} ctx ON (ctx.instanceid = u.id AND ctx.contextlevel = :contextlevel)";
$params['contextlevel'] = CONTEXT_USER;
@ -780,7 +780,7 @@ class core_user_external extends external_api {
// cache all courses
$courses = array();
list($sqlcourseids, $params) = $DB->get_in_or_equal(array_unique($courseids));
list($sqlcourseids, $params) = $DB->get_in_or_equal(array_unique($courseids), SQL_PARAMS_NAMED);
$cselect = ', ' . context_helper::get_preload_record_columns_sql('ctx');
$cjoin = "LEFT JOIN {context} ctx ON (ctx.instanceid = c.id AND ctx.contextlevel = :contextlevel)";
$params['contextlevel'] = CONTEXT_COURSE;
@ -796,7 +796,7 @@ class core_user_external extends external_api {
}
$rs->close();
list($sqluserids, $params) = $DB->get_in_or_equal($userids);
list($sqluserids, $params) = $DB->get_in_or_equal($userids, SQL_PARAMS_NAMED);
$uselect = ', ' . context_helper::get_preload_record_columns_sql('ctx');
$ujoin = "LEFT JOIN {context} ctx ON (ctx.instanceid = u.id AND ctx.contextlevel = :contextlevel)";
$params['contextlevel'] = CONTEXT_USER;