From 0de8a4c2509d740eff6323de679ddf0a3f3edea2 Mon Sep 17 00:00:00 2001 From: Paul Holden Date: Wed, 26 Jun 2024 11:21:36 +0100 Subject: [PATCH] MDL-82301 mod_feedback: remove long ago abandoned tabs element usage. Haven't been used since 773051b98f. --- mod/feedback/analysis.php | 2 - mod/feedback/analysis_course.php | 2 - mod/feedback/edit_item.php | 4 -- mod/feedback/mapcourse.php | 2 - mod/feedback/show_entries.php | 2 - mod/feedback/show_nonrespondents.php | 2 - mod/feedback/tabs.php | 92 ---------------------------- mod/feedback/view.php | 2 - 8 files changed, 108 deletions(-) delete mode 100644 mod/feedback/tabs.php diff --git a/mod/feedback/analysis.php b/mod/feedback/analysis.php index 5641925d628..1cde9c0090b 100644 --- a/mod/feedback/analysis.php +++ b/mod/feedback/analysis.php @@ -25,8 +25,6 @@ require_once("../../config.php"); require_once("lib.php"); -$current_tab = 'analysis'; - $id = required_param('id', PARAM_INT); // Course module id. $url = new moodle_url('/mod/feedback/analysis.php', array('id'=>$id)); diff --git a/mod/feedback/analysis_course.php b/mod/feedback/analysis_course.php index 787d059aef8..3975caeaaf8 100644 --- a/mod/feedback/analysis_course.php +++ b/mod/feedback/analysis_course.php @@ -25,8 +25,6 @@ require_once("../../config.php"); require_once("lib.php"); -$current_tab = 'analysis'; - $id = required_param('id', PARAM_INT); //the POST dominated the GET $courseitemfilter = optional_param('courseitemfilter', '0', PARAM_INT); $courseitemfiltertyp = optional_param('courseitemfiltertyp', '0', PARAM_ALPHANUM); diff --git a/mod/feedback/edit_item.php b/mod/feedback/edit_item.php index 892ec394fc4..0ecb033b747 100644 --- a/mod/feedback/edit_item.php +++ b/mod/feedback/edit_item.php @@ -102,10 +102,6 @@ $PAGE->activityheader->set_attrs([ $PAGE->add_body_class('limitedwidth'); echo $OUTPUT->header(); -/// print the tabs -$current_tab = 'edit'; -$id = $cm->id; - //print errormsg if (isset($error)) { echo $error; diff --git a/mod/feedback/mapcourse.php b/mod/feedback/mapcourse.php index 7c045226efa..cca6996e7ec 100644 --- a/mod/feedback/mapcourse.php +++ b/mod/feedback/mapcourse.php @@ -31,8 +31,6 @@ $id = required_param('id', PARAM_INT); // Course Module ID. $url = new moodle_url('/mod/feedback/mapcourse.php', array('id'=>$id)); $PAGE->set_url($url); -$current_tab = 'mapcourse'; - list($course, $cm) = get_course_and_cm_from_cmid($id, 'feedback'); require_login($course, true, $cm); $feedback = $PAGE->activityrecord; diff --git a/mod/feedback/show_entries.php b/mod/feedback/show_entries.php index 882e87ad5d2..9089d57ca8c 100644 --- a/mod/feedback/show_entries.php +++ b/mod/feedback/show_entries.php @@ -98,8 +98,6 @@ $renderer = $PAGE->get_renderer('mod_feedback'); echo $renderer->main_action_bar($actionbar); echo $OUTPUT->heading(get_string('show_entries', 'mod_feedback'), 3); -$current_tab = 'showentries'; - /// Print the main part of the page /////////////////////////////////////////////////////////////////////////// /////////////////////////////////////////////////////////////////////////// diff --git a/mod/feedback/show_nonrespondents.php b/mod/feedback/show_nonrespondents.php index ace7ddabe92..8fc134e8ad1 100644 --- a/mod/feedback/show_nonrespondents.php +++ b/mod/feedback/show_nonrespondents.php @@ -37,8 +37,6 @@ $messageuser = optional_param_array('messageuser', false, PARAM_INT); $action = optional_param('action', '', PARAM_ALPHA); $perpage = optional_param('perpage', FEEDBACK_DEFAULT_PAGE_COUNT, PARAM_INT); // how many per page $showall = optional_param('showall', false, PARAM_INT); // should we show all users -// $SESSION->feedback->current_tab = $do_show; -$current_tab = 'nonrespondents'; //////////////////////////////////////////////////////// //get the objects diff --git a/mod/feedback/tabs.php b/mod/feedback/tabs.php deleted file mode 100644 index 6c51bf8fccf..00000000000 --- a/mod/feedback/tabs.php +++ /dev/null @@ -1,92 +0,0 @@ -. - -/** - * prints the tabbed bar - * - * @author Andreas Grabs - * @license http://www.gnu.org/copyleft/gpl.html GNU Public License - * @package mod_feedback - */ -defined('MOODLE_INTERNAL') OR die('not allowed'); - -$tabs = array(); -$row = array(); -$inactive = array(); -$activated = array(); - -//some pages deliver the cmid instead the id -if (isset($cmid) AND intval($cmid) AND $cmid > 0) { - $usedid = $cmid; -} else { - $usedid = $id; -} - -$context = context_module::instance($usedid); - -$courseid = optional_param('courseid', false, PARAM_INT); -// $current_tab = $SESSION->feedback->current_tab; -if (!isset($current_tab)) { - $current_tab = ''; -} - -$viewurl = new moodle_url('/mod/feedback/view.php', array('id' => $usedid)); -$row[] = new tabobject('view', $viewurl->out(), get_string('overview', 'feedback')); -$urlparams = ['id' => $usedid]; -if ($feedback->course == SITEID && $courseid) { - $urlparams['courseid'] = $courseid; -} - -if (has_capability('mod/feedback:edititems', $context)) { - $editurl = new moodle_url('/mod/feedback/edit.php', $urlparams + ['do_show' => 'edit']); - $row[] = new tabobject('edit', $editurl->out(), get_string('edit_items', 'feedback')); - - $templateurl = new moodle_url('/mod/feedback/edit.php', $urlparams + ['do_show' => 'templates']); - $row[] = new tabobject('templates', $templateurl->out(), get_string('templates', 'feedback')); -} - -if ($feedback->course == SITEID && has_capability('mod/feedback:mapcourse', $context)) { - $mapurl = new moodle_url('/mod/feedback/mapcourse.php', $urlparams); - $row[] = new tabobject('mapcourse', $mapurl->out(), get_string('mappedcourses', 'feedback')); -} - -if (has_capability('mod/feedback:viewreports', $context)) { - if ($feedback->course == SITEID) { - $analysisurl = new moodle_url('/mod/feedback/analysis_course.php', $urlparams); - } else { - $analysisurl = new moodle_url('/mod/feedback/analysis.php', $urlparams); - } - $row[] = new tabobject('analysis', $analysisurl->out(), get_string('analysis', 'feedback')); - - $reporturl = new moodle_url('/mod/feedback/show_entries.php', $urlparams); - $row[] = new tabobject('showentries', - $reporturl->out(), - get_string('show_entries', 'feedback')); - - if ($feedback->anonymous == FEEDBACK_ANONYMOUS_NO AND $feedback->course != SITEID) { - $nonrespondenturl = new moodle_url('/mod/feedback/show_nonrespondents.php', $urlparams); - $row[] = new tabobject('nonrespondents', - $nonrespondenturl->out(), - get_string('show_nonrespondents', 'feedback')); - } -} - -if (count($row) > 1) { - $tabs[] = $row; - - print_tabs($tabs, $current_tab, $inactive, $activated); -} - diff --git a/mod/feedback/view.php b/mod/feedback/view.php index e62ba8712aa..b9590beff29 100644 --- a/mod/feedback/view.php +++ b/mod/feedback/view.php @@ -27,8 +27,6 @@ require_once($CFG->dirroot . '/mod/feedback/lib.php'); $id = required_param('id', PARAM_INT); $courseid = optional_param('courseid', false, PARAM_INT); -$current_tab = 'view'; - list($course, $cm) = get_course_and_cm_from_cmid($id, 'feedback'); require_course_login($course, true, $cm); $feedback = $PAGE->activityrecord;