mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-04-13 04:22:07 +02:00
Code Issues Projects Releases Wiki Activity

Delete the tweakTempTable() thing used to support temp tables in mssql.

Browse Source 
Was hacky and incomplete. Proper solution must be mssql exclusive.
This commit is contained in:
stronk7 2009-08-28 17:30:18 +00:00
parent 21237187fb
commit 0f887b881e
3 changed files with 0 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/ddl/database_manager.php
View File

@ -492,8 +492,6 @@ class database_manager {
* @return void
*/
public function create_temp_table(xmldb_table $xmldb_table) {
/// hack for mssql - it requires names to start with #
$xmldb_table = $this->generator->tweakTempTable($xmldb_table);
/// Check table doesn't exist
if ($this->table_exists($xmldb_table, true)) {
@ -517,8 +515,6 @@ class database_manager {
* @return void
*/
public function drop_temp_table(xmldb_table $xmldb_table) {
/// mssql requires names to start with #
$xmldb_table = $this->generator->tweakTempTable($xmldb_table);
/// Check table doesn't exist
if (!$this->table_exists($xmldb_table, true)) {

10
lib/ddl/mssql_sql_generator.php
View File

@ -124,16 +124,6 @@ class mssql_sql_generator extends sql_generator {
return $sqlarr;
}
/**
* Tweaks the temp table instance - required for mssql # naming
*/
public function tweakTempTable($xmldb_table) {
if (strpos($xmldb_table->getName(), '#') !== 0) {
$xmldb_table->setName('#'.$xmldb_table->getName()); // MSSQL requires temp table names to start with #
}
return $xmldb_table;
}
/**
* Given one XMLDB Type, lenght and decimals, returns the DB proper SQL type
*/

7
lib/ddl/sql_generator.php
View File

@ -370,13 +370,6 @@ abstract class sql_generator {
return $sqlarr;
}
/**
* Tweaks the temp table instance - required for mssql # naming
*/
public function tweakTempTable($xmldb_table) {
return $xmldb_table;
}
/**
* Given one correct xmldb_index, returns the SQL statements
* needed to create it (in array)