mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-04-21 00:12:56 +02:00
Code Issues Projects Releases Wiki Activity

MDL-29095: initialise_question_instance should use extra_question_fields

Browse Source 
Shortanswer question type converted to use extra question fields.

Signed-off-by: Oleg Sychev <oasychev@gmail.com>
This commit is contained in:
Oleg Sychev 2011-11-14 03:44:49 +03:00 committed by Tim Hunt
parent 6be90ce05f
commit 1067775131
3 changed files with 10 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
question/type/questiontypebase.php
View File

@ -702,6 +702,16 @@ class question_type {
$question->createdby = $questiondata->createdby;
$question->modifiedby = $questiondata->modifiedby;
//Fill extra question fields values
$extraquestionfields = $this->extra_question_fields();
if (is_array($extraquestionfields)) {
//omit table name
array_shift($extraquestionfields);
foreach($extraquestionfields as $field) {
$question->$field = $questiondata->options->$field;
}
}
$this->initialise_question_hints($question, $questiondata);
}

4
question/type/shortanswer/edit_shortanswer_form.php
View File

@ -59,10 +59,6 @@ class qtype_shortanswer_edit_form extends question_edit_form {
$question = $this->data_preprocessing_answers($question);
$question = $this->data_preprocessing_hints($question);
if (!empty($question->options)) {
$question->usecase = $question->options->usecase;
}
return $question;
}

1
question/type/shortanswer/questiontype.php
View File

@ -124,7 +124,6 @@ class qtype_shortanswer extends question_type {
protected function initialise_question_instance(question_definition $question, $questiondata) {
parent::initialise_question_instance($question, $questiondata);
$question->usecase = $questiondata->options->usecase;
$this->initialise_question_answers($question, $questiondata);
}