mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-04-07 09:23:31 +02:00
Code Issues Projects Releases Wiki Activity

MDL-73038 course: remove course module title double encoding.

Browse Source
This commit is contained in:
Paul Holden 2021-11-09 20:25:19 +00:00
parent d135a1200a
commit 10baa46364
2 changed files with 14 additions and 4 deletions
course
format/templates/local/content/cm
title.mustache
tests/behat
activities_edit_name.feature

4
course/format/templates/local/content/cm/title.mustache

@ -36,7 +36,7 @@
<a href="{{url}}" class="aalink {{linkclasses}}" onclick="{{{onclick}}}">
<img class="iconlarge activityicon" src="{{icon}}" alt="" role="presentation" aria-hidden="true" />
<span class="instancename">
{{instancename}} {{{altname}}}
{{{instancename}}} {{{altname}}}
</span>
</a>
{{/uservisible}}
@ -44,7 +44,7 @@
<div class="{{textclasses}}">
<img class="iconlarge activityicon" src="{{icon}}" alt="" role="presentation" aria-hidden="true" />
<span class="instancename">
{{instancename}} {{{altname}}}
{{{instancename}}} {{{altname}}}
</span>
</div>
{{/uservisible}}

14
course/tests/behat/activities_edit_name.feature

@ -4,8 +4,7 @@ Feature: Edit activity name in-place
As a teacher
I need to use inplace editing
@javascript
Scenario: Edit activity name in-place
Background:
Given the following "users" exist:
| username | firstname | lastname | email |
| teacher1 | Teacher | 1 | teacher1@example.com |
@ -21,6 +20,9 @@ Feature: Edit activity name in-place
| name | Test forum name |
| description | Test forum description |
| idnumber | forum1 |
@javascript
Scenario: Edit activity name in-place
When I log in as "teacher1"
And I am on "Course 1" course homepage with editing mode on
# Rename activity
@ -41,3 +43,11 @@ Feature: Edit activity name in-place
And I am on "Course 1" course homepage
And I should see "Good news"
And I should not see "Terrible news"
@javascript
Scenario: Edit activity name in-place ensuring correct encoding
When I log in as "teacher1"
And I am on "Course 1" course homepage with editing mode on
And I set the field "Edit title" in the "Test forum name" "activity" to "Good & bad news"
Then I should not see "Test forum name" in the ".course-content" "css_element"
And I should see "Good & bad news" in the ".course-content" "css_element"