MDL-75610 theme: Allow the activity title in Boost theme's secure layout

This commit is contained in:
Mark Johnson 2024-11-12 11:51:21 +00:00
parent eb7e4a9b65
commit 1262e4539e
No known key found for this signature in database
GPG Key ID: EB30E1468CFAE242
3 changed files with 26 additions and 1 deletions

View File

@ -0,0 +1,19 @@
issueNumber: MDL-75610
notes:
core:
- message: >
`\core\output\activity_header` now uses the `is_title_allowed()` method
when setting the title in the constructor.
This method has been improved to give priority to the 'notitle' option
in the theme config for the current page layout, over the top-level
option in the theme.
For example, the Boost theme sets
`$THEME->activityheaderconfig['notitle'] = true;` by default, but in its
`secure` pagelayout, it has `'notitle' = false`.
This prevents display of the title in all layouts except `secure`.
type: improved

View File

@ -35,4 +35,5 @@ Feature: View the activity header when Safe Exam Browser is required
Scenario: Quiz description is displayed when Safe Exam Browser is required Scenario: Quiz description is displayed when Safe Exam Browser is required
When I am on the "Test quiz name" "quiz activity" page logged in as student1 When I am on the "Test quiz name" "quiz activity" page logged in as student1
Then I should see "Launch Safe Exam Browser" Then I should see "Launch Safe Exam Browser"
And "Test quiz name" "heading" should exist
And I should see "Test quiz description" And I should see "Test quiz description"

View File

@ -164,7 +164,12 @@ $THEME->layouts = [
'secure' => array( 'secure' => array(
'file' => 'secure.php', 'file' => 'secure.php',
'regions' => array('side-pre'), 'regions' => array('side-pre'),
'defaultregion' => 'side-pre' 'defaultregion' => 'side-pre',
'options' => [
'activityheader' => [
'notitle' => false,
],
],
) )
]; ];