mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-01-31 20:53:53 +01:00
Code Issues Projects Releases Wiki Activity

MDL-65731 quiz manual grading: fix ambiguous order by idnumber

Browse Source
This commit is contained in:
Tim Hunt 2019-05-29 13:38:41 +01:00
parent 383aec8a01
commit 12eb2c2bf4
2 changed files with 12 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
mod/quiz/report/grading/report.php
View File

@ -551,6 +551,9 @@ class quiz_grading_report extends quiz_default_report {
case "studentfirstname":
$orderby = "u.firstname, u.lastname";
break;
case "idnumber":
$orderby = "u.idnumber";
break;
}
}

11
mod/quiz/report/grading/tests/behat/grading.feature
View File

@ -1,4 +1,4 @@
@mod @mod_quiz
@mod @mod_quiz @quiz @quiz_grading
Feature: Basic use of the Manual grading report
In order to easily find students attempts that need manual grading
As a teacher
@ -50,8 +50,15 @@ Feature: Basic use of the Manual grading report
And "Short answer 001" row "To grade" column of "questionstograde" table should contain "0"
And "Short answer 001" row "Already graded" column of "questionstograde" table should contain "0"
# Adjust the mark for Student1.
# Go to the grading page.
And I click on "update grades" "link" in the "Short answer 001" "table_row"
And I should see "Grading attempts 1 to 1 of 1"
# Test the display options.
And I set the field "Order attempts" to "By student id number"
And I press "Change options"
# Adjust the mark for Student1.
And I set the field "Comment" to "I have adjusted your mark to 0.6"
And I set the field "Mark" to "0.6"
And I press "Save and go to next page"