mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-04-24 18:04:43 +02:00
Code Issues Projects Releases Wiki Activity

MDL-51036 report_competency: Invalid reference to scale when null

Browse Source
This commit is contained in:
Frederic Massart 2016-01-14 19:34:08 +08:00
parent a4383fe033
commit 131540850a
1 changed files with 15 additions and 1 deletions

16
report/competency/classes/output/report.php

@ -115,6 +115,7 @@ class report implements renderable, templatable {
$data->pluginbaseurl = (new moodle_url('/admin/tool/lp/'))->out(false);
$data->usercompetencies = array();
$scalecache = array();
$frameworkcache = array();
foreach ($this->users as $user) {
$usercompetencies = api::list_user_competencies_in_course($this->courseid, $user->id);
$onerow = new stdClass();
@ -131,7 +132,20 @@ class report implements renderable, templatable {
break;
}
}
if (!isset($scalecache[$competency->get_scaleid()])) {
// Fetch the scale.
$scaleid = $competency->get_scaleid();
if ($scaleid === null) {
if (!isset($frameworkcache[$competency->get_competencyframeworkid()])) {
$frameworkcache[$competency->get_competencyframeworkid()] = $competency->get_framework();
}
$framework = $frameworkcache[$competency->get_competencyframeworkid()];
$scaleid = $framework->get_scaleid();
if (!isset($scalecache[$scaleid])) {
$scalecache[$competency->get_scaleid()] = $framework->get_scale();
}
} else if (!isset($scalecache[$scaleid])) {
$scalecache[$competency->get_scaleid()] = $competency->get_scale();
}
$scale = $scalecache[$competency->get_scaleid()];