mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-04-21 16:32:18 +02:00
Code Issues Projects Releases Wiki Activity

MDL-40907 events: additional legacy logging for module update/add events"

Browse Source
This commit is contained in:
Marina Glancy 2014-02-25 17:26:34 +08:00
parent 957944dca8
commit 158379e173
5 changed files with 18 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
course/dnduploadlib.php
View File

@ -660,10 +660,6 @@ class dndupload_ajax_processor {
));
$event->trigger();
add_to_log($this->course->id, $mod->modname, "add",
"view.php?id=$mod->id",
"$instanceid", $mod->id);
$this->send_response($mod);
}

8
course/modlib.php
View File

@ -160,10 +160,6 @@ function add_moduleinfo($moduleinfo, $course, $mform = null) {
));
$event->trigger();
add_to_log($course->id, $moduleinfo->modulename, "add",
"view.php?id=$moduleinfo->coursemodule",
"$moduleinfo->instance", $moduleinfo->coursemodule);
$moduleinfo = edit_module_post_actions($moduleinfo, $course);
$transaction->allow_commit();
@ -541,10 +537,6 @@ function update_moduleinfo($cm, $moduleinfo, $course, $mform = null) {
));
$event->trigger();
add_to_log($course->id, $moduleinfo->modulename, "update",
"view.php?id=$moduleinfo->coursemodule",
"$moduleinfo->instance", $moduleinfo->coursemodule);
$moduleinfo = edit_module_post_actions($moduleinfo, $course);
return array($cm, $moduleinfo);

10
course/tests/courselib_test.php
View File

@ -1943,7 +1943,10 @@ class core_course_courselib_testcase extends advanced_testcase {
$eventdata->userid = $USER->id;
$this->assertEventLegacyData($eventdata, $event);
$arr = array($cm->course, "course", "add mod", "../mod/assign/view.php?id=$cm->id", "assign $cm->instance");
$arr = array(
array($cm->course, "course", "add mod", "../mod/assign/view.php?id=$cm->id", "assign $cm->instance"),
array($cm->course, "assign", "add", "view.php?id=$cm->id", $cm->instance, $cm->id)
);
$this->assertEventLegacyLogData($arr, $event);
$this->assertEventContextNotUsed($event);
@ -2049,7 +2052,10 @@ class core_course_courselib_testcase extends advanced_testcase {
$eventdata->userid = $USER->id;
$this->assertEventLegacyData($eventdata, $event);
$arr = array($cm->course, "course", "update mod", "../mod/forum/view.php?id=$cm->id", "forum $cm->instance");
$arr = array(
array($cm->course, "course", "update mod", "../mod/forum/view.php?id=$cm->id", "forum $cm->instance"),
array($cm->course, "forum", "update", "view.php?id=$cm->id", $cm->instance, $cm->id)
);
$this->assertEventLegacyLogData($arr, $event);
$this->assertEventContextNotUsed($event);
}

6
lib/classes/event/course_module_created.php
View File

@ -110,8 +110,12 @@ class course_module_created extends base {
* @return array of parameters to be passed to legacy add_to_log() function.
*/
protected function get_legacy_logdata() {
return array ($this->courseid, "course", "add mod", "../mod/" . $this->other['modulename'] . "/view.php?id=" .
$log1 = array($this->courseid, "course", "add mod", "../mod/" . $this->other['modulename'] . "/view.php?id=" .
$this->objectid, $this->other['modulename'] . " " . $this->other['instanceid']);
$log2 = array($this->courseid, $this->other['modulename'], "add",
"view.php?id={$this->objectid}",
"{$this->other['instanceid']}", $this->objectid);
return array($log1, $log2);
}
/**

6
lib/classes/event/course_module_updated.php
View File

@ -110,8 +110,12 @@ class course_module_updated extends base {
* @return array of parameters to be passed to legacy add_to_log() function.
*/
protected function get_legacy_logdata() {
return array ($this->courseid, "course", "update mod", "../mod/" . $this->other['modulename'] . "/view.php?id=" .
$log1 = array($this->courseid, "course", "update mod", "../mod/" . $this->other['modulename'] . "/view.php?id=" .
$this->objectid, $this->other['modulename'] . " " . $this->other['instanceid']);
$log2 = array($this->courseid, $this->other['modulename'], "update",
"view.php?id={$this->objectid}",
"{$this->other['instanceid']}", $this->objectid);
return array($log1, $log2);
}
/**