mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-04-21 08:22:07 +02:00
Code Issues Projects Releases Wiki Activity

MDL-31998 mod_feedback - Feedback depend questions bug

Browse Source
This commit is contained in:
Andreas Grabs 2014-06-10 07:12:26 +02:00
parent 337075d17b
commit 16ee970c94
1 changed files with 16 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
mod/feedback/lib.php
View File

@ -2231,6 +2231,22 @@ function feedback_check_values($firstitem, $lastitem) {
}
$value = $itemobj->clean_input_value($value);
// If the item is not visible due to its dependency so it shouldn't be required.
// Many thanks to Pau Ferrer Ocaña.
if ($item->dependitem > 0 AND $item->required == 1) {
$comparevalue = false;
if ($feedbackcompletedtmp = feedback_get_current_completed($item->feedback, true)) {
$comparevalue = feedback_compare_item_value($feedbackcompletedtmp->id,
$item->dependitem,
$item->dependvalue,
true);
}
if (!$comparevalue) {
$item->required = 0; // Override the required property.
}
}
//check if the value is set
if (is_null($value) AND $item->required == 1) {
return false;