From 17552d4785dd3d6e5eddb54e8bfa01c55ccad64d Mon Sep 17 00:00:00 2001 From: Huong Nguyen Date: Thu, 5 Dec 2024 15:31:57 +0700 Subject: [PATCH] MDL-83606 Question bank: Fix PHPUnit failures --- mod/quiz/tests/quiz_question_bank_view_test.php | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/mod/quiz/tests/quiz_question_bank_view_test.php b/mod/quiz/tests/quiz_question_bank_view_test.php index 91bd5c70091..5d1e2a3c8e0 100644 --- a/mod/quiz/tests/quiz_question_bank_view_test.php +++ b/mod/quiz/tests/quiz_question_bank_view_test.php @@ -96,9 +96,8 @@ class quiz_question_bank_view_test extends \advanced_testcase { // Create a question in the default category. $contexts = new question_edit_contexts($context); - question_make_default_categories($contexts->all()); $cm = get_coursemodule_from_instance('quiz', $quiz->id); - $cat = question_get_default_category($context->id); + $cat = question_get_default_category($context->id, true); // Create three questions. $questiongenerator->create_question('numerical', null, @@ -120,7 +119,7 @@ class quiz_question_bank_view_test extends \advanced_testcase { ]; // Load the question bank view. - $view = new custom_view($contexts, new \moodle_url('/'), $course, $cm, $params, ['cmid' => $cm->id]); + $view = new custom_view($contexts, new \moodle_url('/'), $course, $cm, $params, ['quizcmid' => $cm->id]); ob_start(); $view->display(); $html = ob_get_clean(); @@ -135,7 +134,7 @@ class quiz_question_bank_view_test extends \advanced_testcase { $params['qperpage'] = 2; // Reload the question bank view on page 3. - $view = new custom_view($contexts, new \moodle_url('/'), $course, $cm, $params, ['cmid' => $cm->id]); + $view = new custom_view($contexts, new \moodle_url('/'), $course, $cm, $params, ['quizcmid' => $cm->id]); ob_start(); $view->display(); $html = ob_get_clean(); @@ -158,9 +157,8 @@ class quiz_question_bank_view_test extends \advanced_testcase { // Move question 3 to a new category. question_move_questions_to_category([$question3->id], $newquestioncat->id); // Load the question bank view from the new category. - $params['cat'] = $newquestioncat->id . ',' . $newcontext->id; - $view = new custom_view(new question_edit_contexts($newcontext), - new \moodle_url('/'), $course, $cm, $params, ['cmid' => $cm->id]); + $params['cat'] = $newquestioncat->id . ',' . $newquestioncat->contextid; + $view = new custom_view($contexts, new \moodle_url('/'), $course, $cm, $params, ['quizcmid' => $cm->id]); ob_start(); $view->display(); $html = ob_get_clean();