mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-03-14 04:30:15 +01:00
Code Issues Projects Releases Wiki Activity

MDL-55071 behat: Action menus can be opened without Javascript

Browse Source 
Standard action menus expand automatically when Javascript is disabled
thus there is no need to open them. In Boost, they expand when they're
hovered or when the focus is set on their trigger.
This commit is contained in:
Frédéric Massart 2016-09-28 11:50:09 +02:00
parent a82c49473b
commit 17a6f94749
2 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
lib/tests/behat/behat_action_menu.php
View File

@ -50,7 +50,8 @@ class behat_action_menu extends behat_base {
*/
public function i_open_the_action_menu_in($element, $selectortype) {
if (!$this->running_javascript()) {
throw new DriverException('Open the action menu step is not available with Javascript disabled');
// Action menus automatically expand in a visible list of actions when Javascript is disabled.
return;
}
// Gets the node based on the requested selector type and locator.
$node = $this->get_node_in_container("css_element", "[role=menuitem][aria-haspopup=true]", $selectortype, $element);

3
theme/boost/tests/behat/behat_theme_boost_behat_action_menu.php
View File

@ -38,9 +38,6 @@ require_once(__DIR__ . '/../../../../lib/tests/behat/behat_action_menu.php');
class behat_theme_boost_behat_action_menu extends behat_action_menu {
public function i_open_the_action_menu_in($element, $selectortype) {
if (!$this->running_javascript()) {
throw new DriverException('Open the action menu step is not available with Javascript disabled');
}
// Gets the node based on the requested selector type and locator.
$node = $this->get_node_in_container("css_element", "[role=button][aria-haspopup=true]", $selectortype, $element);
$this->ensure_node_is_visible($node);