mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-01-17 13:38:32 +01:00
Code Issues Projects Releases Wiki Activity

MDL-72772 gradereport_overview: access checks for viewing grades.

Browse Source
This commit is contained in:
Paul Holden 2021-11-25 21:32:20 +00:00 committed by Jun Pataleta
parent 9142285ad6
commit 1964d68f85
2 changed files with 19 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
course/user.php
View File

@ -192,6 +192,9 @@ switch ($mode) {
require_once $CFG->dirroot.'/grade/lib.php';
require_once $CFG->dirroot.'/grade/report/'.$CFG->grade_profilereport.'/lib.php';
// User must be able to view this grade report.
require_capability('gradereport/' . $CFG->grade_profilereport .':view', $coursecontext);
$functionname = 'grade_report_'.$CFG->grade_profilereport.'_profilereport';
if (function_exists($functionname)) {
$functionname($course, $user, $viewasuser);

25
grade/report/overview/lib.php
View File

@ -279,17 +279,24 @@ class grade_report_overview extends grade_report {
$finalgrade = $coursedata['finalgrade'];
$courseitem = $coursedata['courseitem'];
$coursename = format_string(get_course_display_name_for_list($course), true, array('context' => $coursecontext));
// Link to the activity report version of the user grade report.
if ($activitylink) {
$courselink = html_writer::link(new moodle_url('/course/user.php', array('mode' => 'grade', 'id' => $course->id,
'user' => $this->user->id)), $coursename);
} else {
$courselink = html_writer::link(new moodle_url('/grade/report/user/index.php', array('id' => $course->id,
'userid' => $this->user->id, 'group' => $this->gpr->groupid)), $coursename);
$coursenamelink = format_string(get_course_display_name_for_list($course), true, ['context' => $coursecontext]);
// Link to the course grade report pages (performing same capability checks as the pages themselves).
if ($activitylink && has_capability('gradereport/' . $CFG->grade_profilereport .':view', $coursecontext)) {
$coursenamelink = html_writer::link(new moodle_url('/course/user.php', [
'mode' => 'grade',
'id' => $course->id,
'user' => $this->user->id,
]), $coursenamelink);
} else if (!$activitylink && has_capability('gradereport/user:view', $coursecontext)) {
$coursenamelink = html_writer::link(new moodle_url('/grade/report/user/index.php', [
'id' => $course->id,
'userid' => $this->user->id,
'group' => $this->gpr->groupid,
]), $coursenamelink);
}
$data = array($courselink, grade_format_gradevalue($finalgrade, $courseitem, true));
$data = [$coursenamelink, grade_format_gradevalue($finalgrade, $courseitem, true)];
if ($this->showrank['any']) {
if ($this->showrank[$course->id] && !is_null($finalgrade)) {