mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-02-15 21:36:58 +01:00
Code Issues Projects Releases Wiki Activity

mod/quiz: remove deprecated sql_paging_limit(), use offset, limit parameters

Browse Source
This commit is contained in:
martinlanghoff 2006-09-26 05:11:05 +00:00
parent 1e7368e782
commit 1ad5c6380f
2 changed files with 3 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
mod/quiz/report/grading/report.php
View File

@ -240,14 +240,8 @@ class quiz_report extends quiz_default_report {
$total = count_records_sql('SELECT COUNT(DISTINCT('.sql_concat('u.id', '\'#\'', $db->IfNull('qa.attempt', '0')).')) '.$from.$where);
$table->pagesize(10, $total);
// this is for getting the correct records for a given page
if($table->get_page_start() !== '' && $table->get_page_size() !== '') {
$limit = ' '.sql_paging_limit($table->get_page_start(), $table->get_page_size());
} else {
$limit = '';
}
// get the attempts and process them
if ($attempts = get_records_sql($select.$from.$where.$sort.$limit)) {
if ($attempts = get_records_sql($select.$from.$where.$sort,$table->get_page_start(), $table->get_page_size())) {
foreach($attempts as $attempt) {
$picture = print_user_picture($attempt->userid, $quiz->course, $attempt->picture, false, true);

10
mod/quiz/report/overview/report.php
View File

@ -94,7 +94,6 @@ class quiz_report extends quiz_default_report {
if ($download) {
$filename = clean_filename("$course->shortname ".format_string($quiz->name,true));
$sort = '';
$limit = '';
}
// Define table columns
@ -339,12 +338,6 @@ class quiz_report extends quiz_default_report {
$pagesize = 10;
}
$table->pagesize($pagesize, $total);
if($table->get_page_start() !== '' && $table->get_page_size() !== '') {
$limit = ' '.sql_paging_limit($table->get_page_start(), $table->get_page_size());
} else {
$limit = '';
}
}
// If there is feedback, include it in the query.
@ -357,7 +350,8 @@ class quiz_report extends quiz_default_report {
// Fetch the attempts
if (!empty($from)) { // if we're in the site course and displaying no attempts, it makes no sense to do the query.
$attempts = get_records_sql($select.$from.$where.$sort.$limit);
$attempts = get_records_sql($select.$from.$where.$sort,
$table->get_page_start(), $table->get_page_size());
} else {
$attempts = array();
}