mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-01-31 04:33:13 +01:00
Code Issues Projects Releases Wiki Activity

Sharpen up call to 'dangerous' functions.

Browse Source
This commit is contained in:
donal72 2007-08-02 05:35:19 +00:00
parent 2a598439eb
commit 1bef950e2e
1 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
mnet/xmlrpc/server.php
View File

@ -482,12 +482,18 @@ function mnet_server_dispatch($payload) {
} elseif ('dangerous' == $CFG->mnet_dispatcher_mode && $MNET_REMOTE_CLIENT->plaintext_is_ok()) {
$functionname = array_pop($callstack);
$filename = array_pop($callstack);
if ($MNET_REMOTE_CLIENT->plaintext_is_ok()) {
$filename = clean_param(implode('/',$callstack), PARAM_PATH);
if (0 == preg_match("/php$/", $filename)) {
// Filename doesn't end in 'php'; possible attack?
// Generate error response - unable to locate function
exit(mnet_server_fault(7012, 'nosuchfunction'));
}
// The call stack holds the path to any include file
$includefile = $CFG->dirroot.'/'.implode('/',$callstack).'/'.$filename.'.php';
$includefile = $CFG->dirroot.'/'.$filename;
$response = mnet_server_invoke_method($includefile, $functionname, $method, $payload);
echo $response;