mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-04-22 17:02:03 +02:00
Code Issues Projects Releases Wiki Activity

MDL-33587 Improve stored_file::delete_reference() method

Browse Source
This commit is contained in:
David Mudrak 2012-06-07 17:37:25 +02:00
parent 2fa8aea279
commit 1c0da8498f
1 changed files with 25 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

45
lib/filestorage/stored_file.php
View File

@ -142,8 +142,10 @@ class stored_file {
}
}
if ($field == 'referencefileid' or $field == 'referencelastsync' or $field == 'referencelifetime') {
$value = clean_param($value, PARAM_INT);
if ($field === 'referencefileid' or $field === 'referencelastsync' or $field === 'referencelifetime') {
if (!is_null($value) and !is_number($value)) {
throw new file_exception('storedfileproblem', 'Invalid reference info');
}
}
// adding the field
@ -209,30 +211,33 @@ class stored_file {
throw new coding_exception('An attempt to unlink a non-reference file.');
}
// Remove repository info.
$this->repository = null;
$transaction = $DB->start_delegated_transaction();
// Remove reference info from DB.
$DB->delete_records('files_reference', array('id'=>$this->file_record->referencefileid));
// Are we the only one referring to the original file? If so, delete the
// referenced file record. Note we do not use file_storage::search_references_count()
// here because we want to count draft files too and we are at a bit lower access level here.
$countlinks = $DB->count_records('files',
array('referencefileid' => $this->file_record->referencefileid));
if ($countlinks == 1) {
$DB->delete_records('files_reference', array('id' => $this->file_record->referencefileid));
}
// Must refresh $this->file_record form DB
$filerecord = $DB->get_record('files', array('id'=>$this->get_id()));
// Update DB
$filerecord->referencelastsync = null;
$filerecord->referencelifetime = null;
$filerecord->referencefileid = null;
$this->update($filerecord);
// Update the underlying record in the database.
$update = new stdClass();
$update->referencefileid = null;
$update->referencelastsync = null;
$update->referencelifetime = null;
$this->update($update);
$transaction->allow_commit();
// unset object variable
unset($this->file_record->repositoryid);
unset($this->file_record->reference);
unset($this->file_record->referencelastsync);
unset($this->file_record->referencelifetime);
unset($this->file_record->referencefileid);
// Update our properties and the record in the memory.
$this->repository = null;
$this->file_record->repositoryid = null;
$this->file_record->reference = null;
$this->file_record->referencefileid = null;
$this->file_record->referencelastsync = null;
$this->file_record->referencelifetime = null;
}
/**