mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-04-21 00:12:56 +02:00
Code Issues Projects Releases Wiki Activity

MDL-74495 quiz override mark: do not hide_all_feedback

Browse Source
This commit is contained in:
Philipp Imhof 2022-04-13 11:46:28 +02:00
parent 117b24013b
commit 1c9c6c4139
No known key found for this signature in database
GPG Key ID: B0855563879F8BC9
2 changed files with 46 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
mod/quiz/attemptlib.php
View File

@ -1848,7 +1848,7 @@ class quiz_attempt {
*/
public function render_question_for_commenting($slot) {
$options = $this->get_display_options(true);
$options->hide_all_feedback();
$options->generalfeedback = question_display_options::HIDDEN;
$options->manualcomment = question_display_options::EDITABLE;
return $this->quba->render_question($slot, $options,
$this->get_question_number($slot));

45
mod/quiz/tests/behat/feedback_on_override_mark.feature Normal file
View File

@ -0,0 +1,45 @@
@mod @mod_quiz @quiz
Feature: Teachers see correct answers when overriding marks
As a teacher
In order to correct errors
I must be able to override the grades that Moodle gives.
Background:
Given the following "users" exist:
| username | firstname | lastname | email |
| teacher1 | Teacher | 1 | teacher1@example.com |
| student1 | Student | 1 | student0@example.com |
And the following "courses" exist:
| fullname | shortname | category |
| Course 1 | C1 | 0 |
And the following "course enrolments" exist:
| user | course | role |
| teacher1 | C1 | editingteacher |
| student1 | C1 | student |
And the following "question categories" exist:
| contextlevel | reference | name |
| Course | C1 | Test questions |
And the following "questions" exist:
| questioncategory | qtype | name | questiontext | generalfeedback |
| Test questions | shortanswer | Kermit | What kind of animal is Kermit? | |
And the following "activities" exist:
| activity | name | course | idnumber |
| quiz | Quiz 1 | C1 | quiz1 |
And quiz "Quiz 1" contains the following questions:
| question | page |
| Kermit | 1 |
And I am on the "Quiz 1" "mod_quiz > View" page logged in as "student1"
And I press "Attempt quiz"
And I set the field "Answer" to "lion"
And I follow "Finish attempt ..."
And I press "Submit all and finish"
And I click on "Submit all and finish" "button" in the "Confirmation" "dialogue"
And I log out
@javascript @_switch_window @_bug_phantomjs
Scenario: Override marking of a short answer question attempt.
When I am on the "Quiz 1 > student1 > Attempt 1" "mod_quiz > Attempt review" page logged in as "teacher1"
And I follow "Make comment or override mark"
And I switch to "commentquestion" window
Then I should see "The correct answer is: frog"