mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-04-22 08:55:15 +02:00
Code Issues Projects Releases Wiki Activity

datalib: get_logs_user*() - fix invalid SQL - MDL-12426

Browse Source 
Oracle does not accept column labels in the GROUP BY section -
get_logs_usercourse() and get_logs_userday() were computing the
day/hours column and using it in the GROUP BY. The compatible fix
is to reproduce the same computation in the GROUP BY section.

Credit for the fix goes to Dennis Rochford <Dennis.Rochford@usq.edu.au>.
This commit is contained in:
martinlanghoff 2007-12-04 06:26:10 +00:00
parent e88370a6a3
commit 1d854cec5a
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/datalib.php
View File

@ -1941,7 +1941,7 @@ function get_logs_usercourse($userid, $courseid, $coursestart) {
FROM {$CFG->prefix}log
WHERE userid = '$userid'
AND time > '$coursestart' $courseselect
GROUP BY day ");
GROUP BY floor((time - $coursestart)/". DAYSECS .") ");
}
/**
@ -1968,7 +1968,7 @@ function get_logs_userday($userid, $courseid, $daystart) {
FROM {$CFG->prefix}log
WHERE userid = '$userid'
AND time > '$daystart' $courseselect
GROUP BY hour ");
GROUP BY floor((time - $daystart)/". HOURSECS .") ");
}
/**