diff --git a/admin/tool/analytics/classes/output/renderer.php b/admin/tool/analytics/classes/output/renderer.php index edd165dfa35..104ca453b97 100644 --- a/admin/tool/analytics/classes/output/renderer.php +++ b/admin/tool/analytics/classes/output/renderer.php @@ -27,8 +27,7 @@ namespace tool_analytics\output; defined('MOODLE_INTERNAL') || die(); use plugin_renderer_base; -use templatable; -use renderable; + /** * Renderer class. @@ -74,14 +73,12 @@ class renderer extends plugin_renderer_base { * @return string HTML */ public function render_evaluate_results($results, $logs = array()) { - global $OUTPUT; - $output = ''; foreach ($results as $timesplittingid => $result) { if (!CLI_SCRIPT) { - $output .= $OUTPUT->box_start('generalbox mb-3'); + $output .= $this->output->box_start('generalbox mb-3'); } // Check that the array key is a string, not all results depend on time splitting methods (e.g. general errors). @@ -90,47 +87,47 @@ class renderer extends plugin_renderer_base { $langstrdata = (object)array('name' => $timesplitting->get_name(), 'id' => $timesplittingid); if (CLI_SCRIPT) { - $output .= $OUTPUT->heading(get_string('scheduledanalysisresultscli', 'tool_analytics', $langstrdata), 3); + $output .= $this->output->heading(get_string('scheduledanalysisresultscli', 'tool_analytics', $langstrdata), 3); } else { - $output .= $OUTPUT->heading(get_string('scheduledanalysisresults', 'tool_analytics', $langstrdata), 3); + $output .= $this->output->heading(get_string('scheduledanalysisresults', 'tool_analytics', $langstrdata), 3); } } if ($result->status == 0) { - $output .= $OUTPUT->notification(get_string('goodmodel', 'tool_analytics'), + $output .= $this->output->notification(get_string('goodmodel', 'tool_analytics'), \core\output\notification::NOTIFY_SUCCESS); } else if ($result->status === \core_analytics\model::NO_DATASET) { - $output .= $OUTPUT->notification(get_string('nodatatoevaluate', 'tool_analytics'), + $output .= $this->output->notification(get_string('nodatatoevaluate', 'tool_analytics'), \core\output\notification::NOTIFY_WARNING); } if (isset($result->score)) { // Score. - $output .= $OUTPUT->heading(get_string('accuracy', 'tool_analytics') . ': ' . + $output .= $this->output->heading(get_string('accuracy', 'tool_analytics') . ': ' . round(floatval($result->score), 4) * 100 . '%', 4); } if (!empty($result->info)) { foreach ($result->info as $message) { - $output .= $OUTPUT->notification($message, \core\output\notification::NOTIFY_WARNING); + $output .= $this->output->notification($message, \core\output\notification::NOTIFY_WARNING); } } if (!CLI_SCRIPT) { - $output .= $OUTPUT->box_end(); + $output .= $this->output->box_end(); } } // Info logged during evaluation. if (!empty($logs) && debugging()) { - $output .= $OUTPUT->heading(get_string('extrainfo', 'tool_analytics'), 3); + $output .= $this->output->heading(get_string('extrainfo', 'tool_analytics'), 3); foreach ($logs as $log) { - $output .= $OUTPUT->notification($log, \core\output\notification::NOTIFY_WARNING); + $output .= $this->output->notification($log, \core\output\notification::NOTIFY_WARNING); } } if (!CLI_SCRIPT) { - $output .= $OUTPUT->single_button(new \moodle_url('/admin/tool/analytics/index.php'), get_string('continue'), 'get'); + $output .= $this->output->single_button(new \moodle_url('/admin/tool/analytics/index.php'), get_string('continue'), 'get'); } return $output; @@ -147,62 +144,60 @@ class renderer extends plugin_renderer_base { * @return string HTML */ public function render_get_predictions_results($trainresults = false, $trainlogs = array(), $predictresults = false, $predictlogs = array()) { - global $OUTPUT; - $output = ''; if ($trainresults || (!empty($trainlogs) && debugging())) { - $output .= $OUTPUT->heading(get_string('trainingresults', 'tool_analytics'), 3); + $output .= $this->output->heading(get_string('trainingresults', 'tool_analytics'), 3); } if ($trainresults) { if ($trainresults->status == 0) { - $output .= $OUTPUT->notification(get_string('trainingprocessfinished', 'tool_analytics'), + $output .= $this->output->notification(get_string('trainingprocessfinished', 'tool_analytics'), \core\output\notification::NOTIFY_SUCCESS); } else if ($trainresults->status === \core_analytics\model::NO_DATASET || $trainresults->status === \core_analytics\model::NOT_ENOUGH_DATA) { - $output .= $OUTPUT->notification(get_string('nodatatotrain', 'tool_analytics'), + $output .= $this->output->notification(get_string('nodatatotrain', 'tool_analytics'), \core\output\notification::NOTIFY_WARNING); } else { - $output .= $OUTPUT->notification(get_string('generalerror', 'tool_analytics', $trainresults->status), + $output .= $this->output->notification(get_string('generalerror', 'tool_analytics', $trainresults->status), \core\output\notification::NOTIFY_ERROR); } } if (!empty($trainlogs) && debugging()) { - $output .= $OUTPUT->heading(get_string('extrainfo', 'tool_analytics'), 4); + $output .= $this->output->heading(get_string('extrainfo', 'tool_analytics'), 4); foreach ($trainlogs as $log) { - $output .= $OUTPUT->notification($log, \core\output\notification::NOTIFY_WARNING); + $output .= $this->output->notification($log, \core\output\notification::NOTIFY_WARNING); } } if ($predictresults || (!empty($predictlogs) && debugging())) { - $output .= $OUTPUT->heading(get_string('predictionresults', 'tool_analytics'), 3, 'main mt-3'); + $output .= $this->output->heading(get_string('predictionresults', 'tool_analytics'), 3, 'main mt-3'); } if ($predictresults) { if ($predictresults->status == 0) { - $output .= $OUTPUT->notification(get_string('predictionprocessfinished', 'tool_analytics'), + $output .= $this->output->notification(get_string('predictionprocessfinished', 'tool_analytics'), \core\output\notification::NOTIFY_SUCCESS); } else if ($predictresults->status === \core_analytics\model::NO_DATASET || $predictresults->status === \core_analytics\model::NOT_ENOUGH_DATA) { - $output .= $OUTPUT->notification(get_string('nodatatopredict', 'tool_analytics'), + $output .= $this->output->notification(get_string('nodatatopredict', 'tool_analytics'), \core\output\notification::NOTIFY_WARNING); } else { - $output .= $OUTPUT->notification(get_string('generalerror', 'tool_analytics', $predictresults->status), + $output .= $this->output->notification(get_string('generalerror', 'tool_analytics', $predictresults->status), \core\output\notification::NOTIFY_ERROR); } } if (!empty($predictlogs) && debugging()) { - $output .= $OUTPUT->heading(get_string('extrainfo', 'tool_analytics'), 4); + $output .= $this->output->heading(get_string('extrainfo', 'tool_analytics'), 4); foreach ($predictlogs as $log) { - $output .= $OUTPUT->notification($log, \core\output\notification::NOTIFY_WARNING); + $output .= $this->output->notification($log, \core\output\notification::NOTIFY_WARNING); } } if (!CLI_SCRIPT) { - $output .= $OUTPUT->single_button(new \moodle_url('/admin/tool/analytics/index.php'), get_string('continue'), 'get'); + $output .= $this->output->single_button(new \moodle_url('/admin/tool/analytics/index.php'), get_string('continue'), 'get'); } return $output; @@ -236,17 +231,17 @@ class renderer extends plugin_renderer_base { * @return string HTML */ public function render_analytics_disabled() { - global $OUTPUT, $PAGE, $FULLME; + global $FULLME; - $PAGE->set_url($FULLME); - $PAGE->set_title(get_string('pluginname', 'tool_analytics')); - $PAGE->set_heading(get_string('pluginname', 'tool_analytics')); + $this->page->set_url($FULLME); + $this->page->set_title(get_string('pluginname', 'tool_analytics')); + $this->page->set_heading(get_string('pluginname', 'tool_analytics')); - $output = $OUTPUT->header(); - $output .= $OUTPUT->notification(get_string('analyticsdisabled', 'analytics'), \core\output\notification::NOTIFY_INFO); + $output = $this->output->header(); + $output .= $this->output->notification(get_string('analyticsdisabled', 'analytics'), \core\output\notification::NOTIFY_INFO); $output .= \html_writer::tag('a', get_string('continue'), ['class' => 'btn btn-primary', 'href' => (new \moodle_url('/'))->out()]); - $output .= $OUTPUT->footer(); + $output .= $this->output->footer(); return $output; } diff --git a/backup/util/ui/renderer.php b/backup/util/ui/renderer.php index c5312609277..d9bdbe1fa32 100644 --- a/backup/util/ui/renderer.php +++ b/backup/util/ui/renderer.php @@ -277,7 +277,7 @@ class core_backup_renderer extends plugin_renderer_base { */ public function course_selector(moodle_url $nextstageurl, $wholecourse = true, restore_category_search $categories = null, restore_course_search $courses = null, $currentcourse = null) { - global $CFG, $PAGE; + global $CFG; require_once($CFG->dirroot.'/course/lib.php'); // These variables are used to check if the form using this function was submitted. diff --git a/badges/renderer.php b/badges/renderer.php index a95f9ccfeb4..d3c2a6b79d4 100644 --- a/badges/renderer.php +++ b/badges/renderer.php @@ -599,7 +599,7 @@ class core_badges_renderer extends plugin_renderer_base { * @return string */ protected function render_badge_user_collection(\core_badges\output\badge_user_collection $badges) { - global $CFG, $USER, $SITE, $OUTPUT; + global $CFG, $USER, $SITE; $backpack = $badges->backpack; $mybackpack = new moodle_url('/badges/mybackpack.php'); @@ -645,7 +645,7 @@ class core_badges_renderer extends plugin_renderer_base { $externalhtml .= $this->output->heading_with_help(get_string('externalbadges', 'badges'), 'externalbadges', 'badges'); if (!is_null($backpack)) { if ($backpack->backpackid != $CFG->badges_site_backpack) { - $externalhtml .= $OUTPUT->notification(get_string('backpackneedsupdate', 'badges'), 'warning'); + $externalhtml .= $this->output->notification(get_string('backpackneedsupdate', 'badges'), 'warning'); } if ($backpack->totalcollections == 0) { diff --git a/blocks/badges/block_badges.php b/blocks/badges/block_badges.php index 8fb51b65023..96eefc6737d 100644 --- a/blocks/badges/block_badges.php +++ b/blocks/badges/block_badges.php @@ -67,7 +67,7 @@ class block_badges extends block_base { } public function get_content() { - global $USER, $PAGE, $CFG; + global $USER, $CFG; if ($this->content !== null) { return $this->content; @@ -105,4 +105,4 @@ class block_badges extends block_base { return $this->content; } -} \ No newline at end of file +} diff --git a/blocks/comments/block_comments.php b/blocks/comments/block_comments.php index b36faccb265..a54d5cc6087 100644 --- a/blocks/comments/block_comments.php +++ b/blocks/comments/block_comments.php @@ -46,7 +46,7 @@ class block_comments extends block_base { } function get_content() { - global $CFG, $PAGE; + global $CFG; if ($this->content !== NULL) { return $this->content; } @@ -64,10 +64,10 @@ class block_comments extends block_base { if (empty($this->instance)) { return $this->content; } - list($context, $course, $cm) = get_context_info_array($PAGE->context->id); + list($context, $course, $cm) = get_context_info_array($this->page->context->id); $args = new stdClass; - $args->context = $PAGE->context; + $args->context = $this->page->context; $args->course = $course; $args->area = 'page_comments'; $args->itemid = 0; diff --git a/blocks/private_files/block_private_files.php b/blocks/private_files/block_private_files.php index fba811390d6..dcebb0121ab 100644 --- a/blocks/private_files/block_private_files.php +++ b/blocks/private_files/block_private_files.php @@ -41,7 +41,6 @@ class block_private_files extends block_base { } function get_content() { - global $CFG, $USER, $PAGE, $OUTPUT; if ($this->content !== NULL) { return $this->content; @@ -62,7 +61,7 @@ class block_private_files extends block_base { $this->content->text = $renderer->private_files_tree(); if (has_capability('moodle/user:manageownfiles', $this->context)) { $this->content->footer = html_writer::link( - new moodle_url('/user/files.php', array('returnurl' => $PAGE->url->out())), + new moodle_url('/user/files.php', array('returnurl' => $this->page->url->out())), get_string('privatefilesmanage') . '...'); } diff --git a/blocks/rss_client/block_rss_client.php b/blocks/rss_client/block_rss_client.php index 06052c735c3..3f3e292f175 100644 --- a/blocks/rss_client/block_rss_client.php +++ b/blocks/rss_client/block_rss_client.php @@ -59,7 +59,6 @@ * @return block_rss_client\output\footer|null The renderable footer or null if none should be displayed. */ protected function get_footer($feedrecords) { - global $PAGE; $footer = null; if ($this->config->block_rss_client_show_channel_link) { @@ -80,7 +79,8 @@ if ($footer === null) { $footer = new block_rss_client\output\footer(); } - $manageurl = new moodle_url('/blocks/rss_client/managefeeds.php', ['courseid' => $PAGE->course->id]); + $manageurl = new moodle_url('/blocks/rss_client/managefeeds.php', + ['courseid' => $this->page->course->id]); $footer->set_failed($manageurl); } } diff --git a/blocks/settings/block_settings.php b/blocks/settings/block_settings.php index 96f79f9f8a3..e6d9c65079c 100644 --- a/blocks/settings/block_settings.php +++ b/blocks/settings/block_settings.php @@ -90,8 +90,7 @@ class block_settings extends block_base { } function get_required_javascript() { - global $PAGE; - $adminnode = $PAGE->settingsnav->find('siteadministration', navigation_node::TYPE_SITE_ADMIN); + $adminnode = $this->page->settingsnav->find('siteadministration', navigation_node::TYPE_SITE_ADMIN); parent::get_required_javascript(); $arguments = array( 'instanceid' => $this->instance->id, diff --git a/course/classes/management_renderer.php b/course/classes/management_renderer.php index 162a68de549..bece6a18419 100644 --- a/course/classes/management_renderer.php +++ b/course/classes/management_renderer.php @@ -374,9 +374,7 @@ class core_course_management_renderer extends plugin_renderer_base { } public function render_action_menu($menu) { - global $OUTPUT; - - return $OUTPUT->render($menu); + return $this->output->render($menu); } /** diff --git a/course/format/renderer.php b/course/format/renderer.php index 50a5fe1d7b0..7f4beaa5206 100644 --- a/course/format/renderer.php +++ b/course/format/renderer.php @@ -184,8 +184,6 @@ abstract class format_section_renderer_base extends plugin_renderer_base { * @return string HTML to output. */ protected function section_header($section, $course, $onsectionpage, $sectionreturn=null) { - global $PAGE; - $o = ''; $currenttext = ''; $sectionstyle = ''; @@ -270,9 +268,7 @@ abstract class format_section_renderer_base extends plugin_renderer_base { * @return array of edit control items */ protected function section_edit_control_items($course, $section, $onsectionpage = false) { - global $PAGE; - - if (!$PAGE->user_is_editing()) { + if (!$this->page->user_is_editing()) { return array(); } @@ -743,8 +739,6 @@ abstract class format_section_renderer_base extends plugin_renderer_base { * @param int $displaysection The section number in the course which is being displayed */ public function print_single_section_page($course, $sections, $mods, $modnames, $modnamesused, $displaysection) { - global $PAGE; - $modinfo = get_fast_modinfo($course); $course = course_get_format($course)->get_course(); @@ -759,7 +753,7 @@ abstract class format_section_renderer_base extends plugin_renderer_base { // Copy activity clipboard.. echo $this->course_activity_clipboard($course, $displaysection); $thissection = $modinfo->get_section_info(0); - if ($thissection->summary or !empty($modinfo->sections[0]) or $PAGE->user_is_editing()) { + if ($thissection->summary or !empty($modinfo->sections[0]) or $this->page->user_is_editing()) { echo $this->start_section_list(); echo $this->section_header($thissection, $course, true, $displaysection); echo $this->courserenderer->course_section_cm_list($course, $thissection, $displaysection); @@ -828,8 +822,6 @@ abstract class format_section_renderer_base extends plugin_renderer_base { * @param array $modnamesused (argument not used) */ public function print_multiple_section_page($course, $sections, $mods, $modnames, $modnamesused) { - global $PAGE; - $modinfo = get_fast_modinfo($course); $course = course_get_format($course)->get_course(); @@ -849,7 +841,7 @@ abstract class format_section_renderer_base extends plugin_renderer_base { foreach ($modinfo->get_section_info_all() as $section => $thissection) { if ($section == 0) { // 0-section is displayed a little different then the others - if ($thissection->summary or !empty($modinfo->sections[0]) or $PAGE->user_is_editing()) { + if ($thissection->summary or !empty($modinfo->sections[0]) or $this->page->user_is_editing()) { echo $this->section_header($thissection, $course, false, 0); echo $this->courserenderer->course_section_cm_list($course, $thissection, 0); echo $this->courserenderer->course_section_add_cm_control($course, 0, 0); @@ -871,7 +863,7 @@ abstract class format_section_renderer_base extends plugin_renderer_base { continue; } - if (!$PAGE->user_is_editing() && $course->coursedisplay == COURSE_DISPLAY_MULTIPAGE) { + if (!$this->page->user_is_editing() && $course->coursedisplay == COURSE_DISPLAY_MULTIPAGE) { // Display section summary only. echo $this->section_summary($thissection, $course, null); } else { @@ -884,7 +876,7 @@ abstract class format_section_renderer_base extends plugin_renderer_base { } } - if ($PAGE->user_is_editing() and has_capability('moodle/course:update', $context)) { + if ($this->page->user_is_editing() and has_capability('moodle/course:update', $context)) { // Print stealth sections if present. foreach ($modinfo->get_section_info_all() as $section => $thissection) { if ($section <= $numsections or empty($modinfo->sections[$section])) { diff --git a/course/format/topics/renderer.php b/course/format/topics/renderer.php index 67551c574bb..5d11be91148 100644 --- a/course/format/topics/renderer.php +++ b/course/format/topics/renderer.php @@ -104,9 +104,7 @@ class format_topics_renderer extends format_section_renderer_base { * @return array of edit control items */ protected function section_edit_control_items($course, $section, $onsectionpage = false) { - global $PAGE; - - if (!$PAGE->user_is_editing()) { + if (!$this->page->user_is_editing()) { return array(); } diff --git a/grade/grading/form/guide/renderer.php b/grade/grading/form/guide/renderer.php index 1292a9ea75e..ef85ebce3d2 100644 --- a/grade/grading/form/guide/renderer.php +++ b/grade/grading/form/guide/renderer.php @@ -60,7 +60,6 @@ class gradingform_guide_renderer extends plugin_renderer_base { */ public function criterion_template($mode, $options, $elementname = '{NAME}', $criterion = null, $value = null, $validationerrors = null, $comments = null) { - global $PAGE; if ($criterion === null || !is_array($criterion) || !array_key_exists('id', $criterion)) { $criterion = array('id' => '{CRITERION-id}', @@ -254,9 +253,9 @@ class gradingform_guide_renderer extends plugin_renderer_base { } // Include string for JS for the comment chooser title. - $PAGE->requires->string_for_js('insertcomment', 'gradingform_guide'); + $this->page->requires->string_for_js('insertcomment', 'gradingform_guide'); // Include comment_chooser module. - $PAGE->requires->js_call_amd('gradingform_guide/comment_chooser', 'initialise', + $this->page->requires->js_call_amd('gradingform_guide/comment_chooser', 'initialise', array($criterion['id'], $chooserbuttonid, $remarkid, $commentoptions)); } diff --git a/grade/report/user/renderer.php b/grade/report/user/renderer.php index 7062bdd0386..6149d5d071f 100644 --- a/grade/report/user/renderer.php +++ b/grade/report/user/renderer.php @@ -51,8 +51,8 @@ class gradereport_user_renderer extends plugin_renderer_base { * @return string */ public function view_user_selector($userid, $userview) { - global $PAGE, $USER; - $url = $PAGE->url; + global $USER; + $url = $this->page->url; if ($userid != $USER->id) { $url->param('userid', $userid); } diff --git a/lib/outputrenderers.php b/lib/outputrenderers.php index 2a894ee5d8e..28b1b24809e 100644 --- a/lib/outputrenderers.php +++ b/lib/outputrenderers.php @@ -391,12 +391,11 @@ class renderer_base { * @return bool */ public function should_display_main_logo($headinglevel = 1) { - global $PAGE; // Only render the logo if we're on the front page or login page and the we have a logo. $logo = $this->get_logo_url(); if ($headinglevel == 1 && !empty($logo)) { - if ($PAGE->pagelayout == 'frontpage' || $PAGE->pagelayout == 'login') { + if ($this->page->pagelayout == 'frontpage' || $this->page->pagelayout == 'login') { return true; } } @@ -632,7 +631,7 @@ class core_renderer extends renderer_base { * @return string HTML fragment. */ public function standard_head_html() { - global $CFG, $SESSION, $SITE, $PAGE; + global $CFG, $SESSION, $SITE; // Before we output any content, we need to ensure that certain // page components are set up. @@ -728,7 +727,7 @@ class core_renderer extends renderer_base { $output .= "\n".$CFG->additionalhtmlhead; } - if ($PAGE->pagelayout == 'frontpage') { + if ($this->page->pagelayout == 'frontpage') { $summary = s(strip_tags(format_text($SITE->summary, FORMAT_HTML))); if (!empty($summary)) { $output .= "\n"; @@ -867,7 +866,8 @@ class core_renderer extends renderer_base { html_writer::link($purgeurl, get_string('purgecaches', 'admin')) . ''; } if (!empty($CFG->debugvalidators)) { - // NOTE: this is not a nice hack, $PAGE->url is not always accurate and $FULLME neither, it is not a bug if it fails. --skodak + // NOTE: this is not a nice hack, $this->page->url is not always accurate and $FULLME neither, + // it is not a bug if it fails. --skodak $output .= '